From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BD5CC433E6 for ; Thu, 11 Mar 2021 17:00:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4FBAC64FEB for ; Thu, 11 Mar 2021 17:00:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229931AbhCKRAD (ORCPT ); Thu, 11 Mar 2021 12:00:03 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:52248 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229706AbhCKQ7t (ORCPT ); Thu, 11 Mar 2021 11:59:49 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1lKOf2-00ANxe-NU; Thu, 11 Mar 2021 17:59:44 +0100 Date: Thu, 11 Mar 2021 17:59:44 +0100 From: Andrew Lunn To: stefanc@marvell.com Cc: netdev@vger.kernel.org, thomas.petazzoni@bootlin.com, davem@davemloft.net, nadavh@marvell.com, ymarkman@marvell.com, linux-kernel@vger.kernel.org, kuba@kernel.org, linux@armlinux.org.uk, mw@semihalf.com, rmk+kernel@armlinux.org.uk, atenart@kernel.org, rabeeh@solid-run.com Subject: Re: [V2 net-next] net: mvpp2: Add reserved port private flag configuration Message-ID: References: <1615481007-16735-1-git-send-email-stefanc@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1615481007-16735-1-git-send-email-stefanc@marvell.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 11, 2021 at 06:43:27PM +0200, stefanc@marvell.com wrote: > From: Stefan Chulski Hi Stefan Thanks for the strings change. Looks a lot better. Now i took a look at the bigger picture. > According to Armada SoC architecture and design, all the PPv2 ports > which are populated on the same communication processor silicon die > (CP11x) share the same Classifier and Parser engines. > > Armada is an embedded platform and therefore there is a need to reserve > some of the PPv2 ports for different use cases. > > For example, a port can be reserved for a CM3 CPU running FreeRTOS > for management purposes So the CM3 CPU has its own driver for this hardware? It seems like we should not even instantiate the Linux driver for this port. Does the CM3 have its own DT blob? I think the better solution is that the Armada DT for the board does not list the port, and the DT for the CM3 does. Linux never sees the port, since Linux should not be using it. > or by user-space data plane application. You mean XDP/AF_XDP? I don't see any other XDP capable drivers having a flag like this. If this was required, i would expect it to be a common properly, not driver private. Andrew