From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55425C43381 for ; Fri, 12 Mar 2021 11:05:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2EC2764FF9 for ; Fri, 12 Mar 2021 11:05:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233659AbhCLLEe (ORCPT ); Fri, 12 Mar 2021 06:04:34 -0500 Received: from mga02.intel.com ([134.134.136.20]:5499 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233554AbhCLLEA (ORCPT ); Fri, 12 Mar 2021 06:04:00 -0500 IronPort-SDR: Mz/uavYLg1nriw4SDf7sOW10LDGJs9/+ZuAZT6qKGKbt6WBOEuWtTXOMEAKRfqZvh92rdtbeIY ZnKIoa24iBOQ== X-IronPort-AV: E=McAfee;i="6000,8403,9920"; a="175939530" X-IronPort-AV: E=Sophos;i="5.81,243,1610438400"; d="scan'208";a="175939530" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Mar 2021 03:03:58 -0800 IronPort-SDR: /6TpBsSEM7T8QD3s4i9cejjiudGvvwuwTdPHMSBWm5BAzAXBnCnAaOftdYr8trlo9hlgCVfEBG uvC4xBrDbpzQ== X-IronPort-AV: E=Sophos;i="5.81,243,1610438400"; d="scan'208";a="521392591" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Mar 2021 03:03:55 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lKfaB-00BpeO-JN; Fri, 12 Mar 2021 13:03:51 +0200 Date: Fri, 12 Mar 2021 13:03:51 +0200 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Joel Becker , Christoph Hellwig , Shuah Khan , Linus Walleij , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Geert Uytterhoeven , Kent Gibson , Jonathan Corbet , Greg Kroah-Hartman , "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List , linux-doc , Bartosz Golaszewski Subject: Re: [PATCH v3 08/11] gpio: sim: new testing module Message-ID: References: <20210309205921.15992-1-brgl@bgdev.pl> <20210309205921.15992-9-brgl@bgdev.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 12, 2021 at 09:54:58AM +0100, Bartosz Golaszewski wrote: > On Wed, Mar 10, 2021 at 1:28 PM Andy Shevchenko > wrote: ... > > > + ret = sprintf(page, "n/a\n"); > > > > I dunno '/' (slash) is a good character to be handled in a shell. > > I would prefer 'none' or 'not available' (I think space is easier, > > because the rules to escape much simpler: need just to take it into > > quotes, while / needs to be escaped separately). > > > > My test cases work fine with 'n/a' but I can change it to 'none' if > it's less controversial. % git grep -n -w '"none"' -- drivers/ arch/ | wc -l 371 % git grep -n -w '"n/a"' -- drivers/ arch/ | wc -l 15 % git grep -n -w '"not available"' -- drivers/ arch/ | wc -l 5 ... > But I would be creating empty properties for nothing. Better to just > not have them at all. Up to you. -- With Best Regards, Andy Shevchenko