From: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
To: Lee Jones <lee.jones@linaro.org>
Cc: Andreas Kemnade <andreas@kemnade.info>,
j.neuschaefer@gmx.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mfd: ntxec: Support for EC in Tolino Shine 2 HD
Date: Sat, 13 Mar 2021 12:17:34 +0100 [thread overview]
Message-ID: <YEyfTrTFzUaXiklf@latitude> (raw)
In-Reply-To: <20210310095545.GC701493@dell>
[-- Attachment #1: Type: text/plain, Size: 873 bytes --]
On Wed, Mar 10, 2021 at 09:55:45AM +0000, Lee Jones wrote:
> On Mon, 08 Mar 2021, Andreas Kemnade wrote:
[...]
> > -static const struct mfd_cell ntxec_subdevices[] = {
> > +static const struct mfd_cell ntxec_subdev[] = {
> > { .name = "ntxec-rtc" },
> > { .name = "ntxec-pwm" },
> > };
> >
> > +static const struct mfd_cell ntxec_subdev_pwm[] = {
> > + { .name = "ntxec-pwm" },
> > +};
>
> To put across what you're trying to achieve, maybe call this:
>
> ntxec_subdev_no_rtc[]
>
> Then if other devices are added, the semantics/intent stays the same
> and it won't have to be renamed.
Andreas, what is the full amount of functionality this version of the EC
can ever provide?
If it's only PWM, I think ntxec_subdev_pwm fits well.
[ The next subdevice that I can foresee is battery monitoring. ]
Sorry for the delay,
Jonathan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-03-13 11:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 21:29 [PATCH v2] mfd: ntxec: Support for EC in Tolino Shine 2 HD Andreas Kemnade
2021-03-08 22:07 ` Jonathan Neuschäfer
2021-03-10 9:48 ` Lee Jones
2021-03-11 18:40 ` Mark Brown
2021-03-22 14:59 ` Lee Jones
2021-03-23 17:11 ` Mark Brown
2021-03-23 17:20 ` Lee Jones
2021-03-23 17:48 ` Mark Brown
2021-03-23 18:52 ` Lee Jones
2021-03-23 19:44 ` Mark Brown
2021-03-10 9:55 ` Lee Jones
2021-03-13 11:17 ` Jonathan Neuschäfer [this message]
2021-03-13 15:07 ` Andreas Kemnade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEyfTrTFzUaXiklf@latitude \
--to=j.neuschaefer@gmx.net \
--cc=andreas@kemnade.info \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox