From: Bhaskar Chowdhury <unixbhaskar@gmail.com>
To: dsterba@suse.cz, clm@fb.com, josef@toxicpanda.com,
dsterba@suse.com, linux-btrfs@vger.kernel.org,
linux-kernel@vger.kernel.org, rdunlap@infradead.org
Subject: Re: [PATCH] btrfs: fixed rudimentary typos
Date: Fri, 26 Mar 2021 05:25:39 +0530 [thread overview]
Message-ID: <YF0i+2N7NSyHkTYB@Gentoo> (raw)
In-Reply-To: <20210325214704.GM7604@twin.jikos.cz>
[-- Attachment #1: Type: text/plain, Size: 1433 bytes --]
On 22:47 Thu 25 Mar 2021, David Sterba wrote:
>On Thu, Mar 25, 2021 at 11:40:04PM +0530, Bhaskar Chowdhury wrote:
>> On 13:49 Thu 25 Mar 2021, David Sterba wrote:
>> >On Thu, Mar 25, 2021 at 09:51:13AM +0530, Bhaskar Chowdhury wrote:
>> >>
>> >> s/contaning/containing
>> >> s/clearning/clearing/
>> >
>> >Have hou scanned the whole subdirectory for typos? We do typo fixing
>> >about once a year in one big patch and won't fix them one by one.
>>
>> Once a year???? You must be kidding! that is not good whatever the workflow
>> you have .
>
>No kidding. It's even worse, we get that every two years.
>
>* 2016 0132761017e012ab4dc8584d679503f2ba26ca86
> 33 files changed, 106 insertions(+), 105 deletions(-)
>
>* 2018 52042d8e82ff50d40e76a275ac0b97aa663328b0
> 25 files changed, 70 insertions(+), 69 deletions(-)
>
>You can see the diffstat touches nearly all the files, almost hundred of
>fixed typos per patch. Now compare that to sending 70-100 individual
>patches. Time spent on any patch is not zero and for such trivial
>changes it's not justified so the workflow is to do that in batches.
>If you care about fixing typos in fs/btrfs/, please fix them all. I've
>found about 50.
I certainly do , not only for btrfs but for the whole kernel, it might sound
ridiculous , but someone has to bell the cat , right?
If I get little cooperation from everyone , we can pull it through, it would
be good for the future generation.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2021-03-25 23:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 4:21 [PATCH] btrfs: fixed rudimentary typos Bhaskar Chowdhury
2021-03-25 12:49 ` David Sterba
2021-03-25 18:10 ` Bhaskar Chowdhury
2021-03-25 21:47 ` David Sterba
2021-03-25 23:55 ` Bhaskar Chowdhury [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YF0i+2N7NSyHkTYB@Gentoo \
--to=unixbhaskar@gmail.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox