From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D042C433DB for ; Fri, 26 Mar 2021 16:21:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 29A6F619CB for ; Fri, 26 Mar 2021 16:21:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230454AbhCZQUv (ORCPT ); Fri, 26 Mar 2021 12:20:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:37026 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230240AbhCZQUo (ORCPT ); Fri, 26 Mar 2021 12:20:44 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2E7FE60238; Fri, 26 Mar 2021 16:20:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1616775643; bh=sGeQMMUyCKfthnoYlkyFne9XUQZHWtH80Xz18/AFaVc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DqUu5ia43uoH46rVofPH4b+KKApSPiR5P5JZUf6i3lll9KknyEQApOOGxaO52OooW NxZXIJZuj7EFkyD3g75PBc9rGcqQXR3OkPwFtchUnLVMHeiyVdM05HmXEURxXAZzrw gSnqx0CsqH5i6PE7B4KROUi15iD8EWKxOp5tEli0= Date: Fri, 26 Mar 2021 17:20:40 +0100 From: Greg KH To: Fabio Aiuto Cc: dan.carpenter@oracle.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Fixes: 65f183001f6e (staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_INTERRUPT_BASED_TXBCN*) Message-ID: References: <20210326155252.6746-1-fabioaiuto83@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210326155252.6746-1-fabioaiuto83@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 26, 2021 at 04:52:52PM +0100, Fabio Aiuto wrote: > fix indentation broken by patch removing conditional > code blocks checked by unused > CONFIG_INTERRUPT_BASED_TXBCN family defines > > https://lore.kernel.org/r/9157000821fd6febf25566b8c712fad1995c7c78.1615907632.git.fabioaiuto83@gmail.com No, please use a "Fixes:" tag that points to the git commit id that this commit fixes. Look in the kernel tree for loads of examples of how to do this, and it's even documented in the Documentation/ process guide as well. thanks, greg k-h