From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95059C433E1 for ; Fri, 26 Mar 2021 17:35:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3F58761A13 for ; Fri, 26 Mar 2021 17:35:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230249AbhCZReu (ORCPT ); Fri, 26 Mar 2021 13:34:50 -0400 Received: from relay12.mail.gandi.net ([217.70.178.232]:47643 "EHLO relay12.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230076AbhCZRee (ORCPT ); Fri, 26 Mar 2021 13:34:34 -0400 Received: from localhost (lfbn-lyo-1-1676-55.w90-65.abo.wanadoo.fr [90.65.108.55]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 5D213200004; Fri, 26 Mar 2021 17:34:32 +0000 (UTC) Date: Fri, 26 Mar 2021 18:34:31 +0100 From: Alexandre Belloni To: Lee Jones Cc: Russell King , linux-kernel@vger.kernel.org, Ludovic Desroches , linux-arm-kernel@lists.infradead.org Subject: Re: [RESEND 1/1] arch: arm: mach-at91: pm: Move prototypes to mutually included header Message-ID: References: <20210303124149.3149511-1-lee.jones@linaro.org> <161677907718.203839.17372873158505015568.b4-ty@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <161677907718.203839.17372873158505015568.b4-ty@bootlin.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/03/2021 18:18:04+0100, Alexandre Belloni wrote: > On Wed, 3 Mar 2021 12:41:49 +0000, Lee Jones wrote: > > Both the caller and the supplier's source file should have access to > > the include file containing the prototypes. > > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/pinctrl/pinctrl-at91.c:1637:6: warning: no previous prototype for ‘at91_pinctrl_gpio_suspend’ [-Wmissing-prototypes] > > 1637 | void at91_pinctrl_gpio_suspend(void) > > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > > drivers/pinctrl/pinctrl-at91.c:1661:6: warning: no previous prototype for ‘at91_pinctrl_gpio_resume’ [-Wmissing-prototypes] > > 1661 | void at91_pinctrl_gpio_resume(void) > > | ^~~~~~~~~~~~~~~~~~~~~~~~ > > Applied, thanks! > > [1/1] arch: arm: mach-at91: pm: Move prototypes to mutually included header > commit: 10e9119e865047f4e22cbd69de991d6bc26c4faf > Actually: [1/1] ARM: at91: pm: Move prototypes to mutually included header commit: 41dbf4a146a06443d1cbf39e238f02fa1ca9d626 -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com