From: Peter Zijlstra <peterz@infradead.org>
To: Huaixin Chang <changhuaixin@linux.alibaba.com>
Cc: bsegall@google.com, dietmar.eggemann@arm.com,
juri.lelli@redhat.com, khlebnikov@yandex-team.ru,
linux-kernel@vger.kernel.org, mgorman@suse.de, mingo@redhat.com,
odin@uged.al, odin@ugedal.com, pauld@redhead.com, pjt@google.com,
rostedt@goodmis.org, shanpeic@linux.alibaba.com, tj@kernel.org,
vincent.guittot@linaro.org, xiyou.wangcong@gmail.com
Subject: Re: [PATCH v4 1/4] sched/fair: Introduce primitives for CFS bandwidth burst
Date: Tue, 16 Mar 2021 10:54:37 +0100 [thread overview]
Message-ID: <YFCAXeZj6sXBI5Ls@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20210316044931.39733-2-changhuaixin@linux.alibaba.com>
On Tue, Mar 16, 2021 at 12:49:28PM +0800, Huaixin Chang wrote:
> @@ -8982,6 +8983,12 @@ static int tg_set_cfs_bandwidth(struct task_group *tg, u64 period, u64 quota)
> if (quota != RUNTIME_INF && quota > max_cfs_runtime)
> return -EINVAL;
>
> + /*
> + * Bound burst to defend burst against overflow during bandwidth shift.
> + */
> + if (burst > max_cfs_runtime)
> + return -EINVAL;
Why do you allow such a large burst? I would expect something like:
if (burst > quote)
return -EINVAL;
That limits the variance in the system. Allowing super long bursts seems
to defeat the entire purpose of bandwidth control.
next prev parent reply other threads:[~2021-03-16 9:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 4:49 [PATCH v4 0/4] sched/fair: Burstable CFS bandwidth controller Huaixin Chang
2021-03-16 4:49 ` [PATCH v4 1/4] sched/fair: Introduce primitives for CFS bandwidth burst Huaixin Chang
2021-03-16 9:27 ` Peter Zijlstra
2021-03-16 9:41 ` Peter Zijlstra
2021-03-16 9:54 ` Peter Zijlstra [this message]
2021-03-17 7:16 ` changhuaixin
2021-03-17 8:06 ` Peter Zijlstra
2021-03-18 1:26 ` changhuaixin
2021-03-18 12:59 ` Phil Auld
2021-03-18 15:10 ` Peter Zijlstra
2021-04-19 8:18 ` changhuaixin
2021-03-19 12:51 ` changhuaixin
2021-03-18 15:05 ` Peter Zijlstra
2021-03-19 12:39 ` changhuaixin
2021-03-20 2:06 ` changhuaixin
2021-05-12 12:41 ` changhuaixin
2021-03-16 10:40 ` Peter Zijlstra
2021-03-16 4:49 ` [PATCH v4 2/4] sched/fair: Make CFS bandwidth controller burstable Huaixin Chang
2021-03-16 9:52 ` Peter Zijlstra
2021-03-16 4:49 ` [PATCH v4 3/4] sched/fair: Add cfs bandwidth burst statistics Huaixin Chang
2021-03-16 4:49 ` [PATCH v4 4/4] sched/fair: Add document for burstable CFS bandwidth control Huaixin Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFCAXeZj6sXBI5Ls@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bsegall@google.com \
--cc=changhuaixin@linux.alibaba.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=khlebnikov@yandex-team.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=odin@uged.al \
--cc=odin@ugedal.com \
--cc=pauld@redhead.com \
--cc=pjt@google.com \
--cc=rostedt@goodmis.org \
--cc=shanpeic@linux.alibaba.com \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox