From: Peter Zijlstra <peterz@infradead.org>
To: "Zhou Ti (x2019cwm)" <x2019cwm@stfx.ca>,
g@hirez.programming.kicks-ass.net
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Frederic Weisbecker <frederic@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
Yunfeng Ye <yeyunfeng@huawei.com>,
"Paul E . McKenney" <paulmck@kernel.org>,
Marcelo Tosatti <mtosatti@redhat.com>,
Ingo Molnar <mingo@kernel.org>,
"rafael@kernel.org" <rafael@kernel.org>
Subject: Re: 回复: [PATCH 01/10] tick/nohz: Prevent tick_nohz_get_sleep_length() from returning negative value
Date: Tue, 16 Mar 2021 17:25:20 +0100 [thread overview]
Message-ID: <YFDb8AzfajvlZ6iS@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <YTBPR01MB3262D78448BD2FB3AD5EB4F9C46B9@YTBPR01MB3262.CANPRD01.PROD.OUTLOOK.COM>
On Tue, Mar 16, 2021 at 04:08:08PM +0000, Zhou Ti (x2019cwm) wrote:
> But I don't think it's a good idea to handle this in callers, because
> logically the function shouldn't return negative values. Returning 0
> directly would allow idle governors to get another chance to select
> again.
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
next prev parent reply other threads:[~2021-03-16 16:26 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 12:36 [PATCH 00/10] tick/nohz updates Frederic Weisbecker
2021-03-11 12:36 ` [PATCH 01/10] tick/nohz: Prevent tick_nohz_get_sleep_length() from returning negative value Frederic Weisbecker
2021-03-16 12:21 ` Peter Zijlstra
2021-03-16 13:37 ` Frederic Weisbecker
2021-03-16 14:35 ` Peter Zijlstra
2021-03-16 14:53 ` Frederic Weisbecker
2021-03-16 15:26 ` Rafael J. Wysocki
2021-03-16 15:57 ` 回复: " Zhou Ti (x2019cwm)
2021-03-16 16:08 ` Zhou Ti (x2019cwm)
2021-03-16 16:25 ` Peter Zijlstra [this message]
2021-03-17 21:49 ` Zhou Ti (x2019cwm)
2021-03-25 13:14 ` Frederic Weisbecker
2021-03-25 18:56 ` Rafael J. Wysocki
2021-03-25 19:18 ` Zhou Ti (x2019cwm)
2021-03-25 19:50 ` Rafael J. Wysocki
2021-03-25 20:37 ` Zhou Ti (x2019cwm)
2021-03-26 17:01 ` Rafael J. Wysocki
2021-03-26 17:53 ` Zhou Ti (x2019cwm)
2021-03-26 18:54 ` Rafael J. Wysocki
2021-03-26 22:53 ` Zhou Ti (x2019cwm)
2021-03-29 12:44 ` Rafael J. Wysocki
2021-03-29 14:49 ` Zhou Ti (x2019cwm)
2021-03-11 12:37 ` [PATCH 02/10] tick/nohz: Add tick_nohz_full_this_cpu() Frederic Weisbecker
2021-03-16 12:28 ` Peter Zijlstra
2021-03-16 13:05 ` Frederic Weisbecker
2021-03-11 12:37 ` [PATCH 03/10] tick/nohz: Conditionally restart tick on idle exit Frederic Weisbecker
2021-03-11 12:37 ` [PATCH 04/10] tick/nohz: Remove superflous check for CONFIG_VIRT_CPU_ACCOUNTING_NATIVE Frederic Weisbecker
2021-03-11 12:37 ` [PATCH 05/10] tick/nohz: Update idle_exittime on actual idle exit Frederic Weisbecker
2021-03-11 12:37 ` [PATCH 06/10] timer: Report ignored local enqueue in nohz mode Frederic Weisbecker
2021-03-16 15:27 ` Peter Zijlstra
2021-03-25 13:07 ` Frederic Weisbecker
2021-03-11 12:37 ` [PATCH 07/10] tick/nohz: Update nohz_full Kconfig help Frederic Weisbecker
2021-03-11 12:37 ` [PATCH 08/10] tick/nohz: Only wakeup a single target cpu when kicking a task Frederic Weisbecker
2021-03-11 12:37 ` [PATCH 09/10] tick/nohz: Change signal tick dependency to wakeup CPUs of member tasks Frederic Weisbecker
2021-03-11 12:37 ` [PATCH 10/10] tick/nohz: Kick only _queued_ task whose tick dependency is updated Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFDb8AzfajvlZ6iS@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=frederic@kernel.org \
--cc=g@hirez.programming.kicks-ass.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mtosatti@redhat.com \
--cc=paulmck@kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=tglx@linutronix.de \
--cc=x2019cwm@stfx.ca \
--cc=yeyunfeng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox