[PATCH] kernel: debug: Ordinary typo fixes in the file gdbstub.c

[PATCH] kernel: debug: Ordinary typo fixes in the file gdbstub.c

[Bhaskar Chowdhury]

s/'O'utput/'Output/
s/overwitten/overwritten/
s/procesing/processing/

Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
---
 kernel/debug/gdbstub.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/kernel/debug/gdbstub.c b/kernel/debug/gdbstub.c
index e149a0ac9e9e..5c96590725f1 100644
--- a/kernel/debug/gdbstub.c
+++ b/kernel/debug/gdbstub.c
@@ -204,7 +204,7 @@ void gdbstub_msg_write(const char *s, int len)
 	if (len == 0)
 		len = strlen(s);

-	/* 'O'utput */
+	/* 'Output */
 	gdbmsgbuf[0] = 'O';

 	/* Fill and send buffers... */
@@ -321,7 +321,7 @@ int kgdb_hex2long(char **ptr, unsigned long *long_val)
 /*
  * Copy the binary array pointed to by buf into mem.  Fix $, #, and
  * 0x7d escaped with 0x7d. Return -EFAULT on failure or 0 on success.
- * The input buf is overwitten with the result to write to mem.
+ * The input buf is overwritten with the result to write to mem.
  */
 static int kgdb_ebin2mem(char *buf, char *mem, int count)
 {
@@ -952,7 +952,7 @@ static int gdb_cmd_exception_pass(struct kgdb_state *ks)
 }

 /*
- * This function performs all gdbserial command procesing
+ * This function performs all gdbserial command processing
  */
 int gdb_serial_stub(struct kgdb_state *ks)
 {
--
2.30.2

Re: [PATCH] kernel: debug: Ordinary typo fixes in the file gdbstub.c

[Daniel Thompson]

On Wed, Mar 17, 2021 at 02:40:22PM +0530, Bhaskar Chowdhury wrote:
> 
> s/'O'utput/'Output/
> s/overwitten/overwritten/
> s/procesing/processing/
> 
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> ---
>  kernel/debug/gdbstub.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/kernel/debug/gdbstub.c b/kernel/debug/gdbstub.c
> index e149a0ac9e9e..5c96590725f1 100644
> --- a/kernel/debug/gdbstub.c
> +++ b/kernel/debug/gdbstub.c
> @@ -204,7 +204,7 @@ void gdbstub_msg_write(const char *s, int len)
>  	if (len == 0)
>  		len = strlen(s);
> 
> -	/* 'O'utput */
> +	/* 'Output */

This is not a typo.

It is showing that the 'O' being writing into the message buffer is a
mnemonic and describing what it expands to.

Other changes look good, please can you resend with this one removed?


Daniel.


>  	gdbmsgbuf[0] = 'O';
> 
>  	/* Fill and send buffers... */
> @@ -321,7 +321,7 @@ int kgdb_hex2long(char **ptr, unsigned long *long_val)
>  /*
>   * Copy the binary array pointed to by buf into mem.  Fix $, #, and
>   * 0x7d escaped with 0x7d. Return -EFAULT on failure or 0 on success.
> - * The input buf is overwitten with the result to write to mem.
> + * The input buf is overwritten with the result to write to mem.
>   */
>  static int kgdb_ebin2mem(char *buf, char *mem, int count)
>  {
> @@ -952,7 +952,7 @@ static int gdb_cmd_exception_pass(struct kgdb_state *ks)
>  }
> 
>  /*
> - * This function performs all gdbserial command procesing
> + * This function performs all gdbserial command processing
>   */
>  int gdb_serial_stub(struct kgdb_state *ks)
>  {
> --
> 2.30.2
> 

Re: [PATCH] kernel: debug: Ordinary typo fixes in the file gdbstub.c

[Bhaskar Chowdhury]

[-- Attachment #1: Type: text/plain, Size: 1768 bytes --]

On 10:36 Wed 17 Mar 2021, Daniel Thompson wrote:
>On Wed, Mar 17, 2021 at 02:40:22PM +0530, Bhaskar Chowdhury wrote:
>>
>> s/'O'utput/'Output/
>> s/overwitten/overwritten/
>> s/procesing/processing/
>>
>> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
>> ---
>>  kernel/debug/gdbstub.c | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/kernel/debug/gdbstub.c b/kernel/debug/gdbstub.c
>> index e149a0ac9e9e..5c96590725f1 100644
>> --- a/kernel/debug/gdbstub.c
>> +++ b/kernel/debug/gdbstub.c
>> @@ -204,7 +204,7 @@ void gdbstub_msg_write(const char *s, int len)
>>  	if (len == 0)
>>  		len = strlen(s);
>>
>> -	/* 'O'utput */
>> +	/* 'Output */
>
>This is not a typo.
>
>It is showing that the 'O' being writing into the message buffer is a
>mnemonic and describing what it expands to.
>
>Other changes look good, please can you resend with this one removed?
>
>
Sure, thanks Daniel....V2 on the way...

>Daniel.
>
>
>>  	gdbmsgbuf[0] = 'O';
>>
>>  	/* Fill and send buffers... */
>> @@ -321,7 +321,7 @@ int kgdb_hex2long(char **ptr, unsigned long *long_val)
>>  /*
>>   * Copy the binary array pointed to by buf into mem.  Fix $, #, and
>>   * 0x7d escaped with 0x7d. Return -EFAULT on failure or 0 on success.
>> - * The input buf is overwitten with the result to write to mem.
>> + * The input buf is overwritten with the result to write to mem.
>>   */
>>  static int kgdb_ebin2mem(char *buf, char *mem, int count)
>>  {
>> @@ -952,7 +952,7 @@ static int gdb_cmd_exception_pass(struct kgdb_state *ks)
>>  }
>>
>>  /*
>> - * This function performs all gdbserial command procesing
>> + * This function performs all gdbserial command processing
>>   */
>>  int gdb_serial_stub(struct kgdb_state *ks)
>>  {
>> --
>> 2.30.2
>>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]