From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Badhri Jagan Sridharan <badhri@google.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] usb: typec: tcpci: Added few missing TCPCI register definitions
Date: Wed, 17 Mar 2021 17:42:58 +0100 [thread overview]
Message-ID: <YFIxkh8XLDiszci7@kroah.com> (raw)
In-Reply-To: <4f077e6c-4e95-ab54-c549-e953bf3c00f3@roeck-us.net>
On Tue, Mar 16, 2021 at 03:52:58PM -0700, Guenter Roeck wrote:
> On 3/16/21 3:13 PM, Badhri Jagan Sridharan wrote:
> > This change adds some of the register bit definitions from the TCPCI spec:
> > https://www.usb.org/sites/default/files/documents/
> > usb-port_controller_specification_rev2.0_v1.0_0.pdf
> >
> > Signed-off-by: Badhri Jagan Sridharan <badhri@google.com>
>
> Are those going to be used ?
For values and #defines that are in public specs, does it matter? It's
good to have full definitions in the .h files for whenever possible for
stuff like this to make it easy for people to write code to use them :)
thanks,
greg k-h
next prev parent reply other threads:[~2021-03-17 16:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 22:13 [PATCH v1] usb: typec: tcpci: Added few missing TCPCI register definitions Badhri Jagan Sridharan
2021-03-16 22:52 ` Guenter Roeck
2021-03-17 16:42 ` Greg Kroah-Hartman [this message]
2021-03-17 17:58 ` Guenter Roeck
2021-03-17 18:03 ` Greg Kroah-Hartman
2021-03-17 19:20 ` Guenter Roeck
2021-03-18 7:41 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFIxkh8XLDiszci7@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=badhri@google.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox