* [PATCH] drm/amdgpu: Fix a typo
@ 2021-03-18 11:33 Bhaskar Chowdhury
2021-03-18 18:07 ` Randy Dunlap
0 siblings, 1 reply; 8+ messages in thread
From: Bhaskar Chowdhury @ 2021-03-18 11:33 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel,
Hawking.Zhang, John.Clements, guchun.chen, tao.zhou1, Likun.Gao,
Bhawanpreet.Lakha, Jiansong.Chen, ray.huang, amd-gfx, dri-devel,
linux-kernel
Cc: rdunlap, Bhaskar Chowdhury
s/traing/training/
Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
---
drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
index c325d6f53a71..db18e4f6cf5f 100644
--- a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
@@ -661,7 +661,7 @@ static int psp_v11_0_memory_training(struct psp_context *psp, uint32_t ops)
if (ops & PSP_MEM_TRAIN_SEND_LONG_MSG) {
/*
- * Long traing will encroach certain mount of bottom VRAM,
+ * Long training will encroach certain mount of bottom VRAM,
* saving the content of this bottom VRAM to system memory
* before training, and restoring it after training to avoid
* VRAM corruption.
--
2.26.2
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] drm/amdgpu: Fix a typo
2021-03-18 11:33 [PATCH] drm/amdgpu: Fix a typo Bhaskar Chowdhury
@ 2021-03-18 18:07 ` Randy Dunlap
2021-03-18 18:12 ` Alex Deucher
0 siblings, 1 reply; 8+ messages in thread
From: Randy Dunlap @ 2021-03-18 18:07 UTC (permalink / raw)
To: Bhaskar Chowdhury, alexander.deucher, christian.koenig, airlied,
daniel, Hawking.Zhang, John.Clements, guchun.chen, tao.zhou1,
Likun.Gao, Bhawanpreet.Lakha, Jiansong.Chen, ray.huang, amd-gfx,
dri-devel, linux-kernel
On 3/18/21 4:33 AM, Bhaskar Chowdhury wrote:
>
> s/traing/training/
>
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> ---
> drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> index c325d6f53a71..db18e4f6cf5f 100644
> --- a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> @@ -661,7 +661,7 @@ static int psp_v11_0_memory_training(struct psp_context *psp, uint32_t ops)
>
> if (ops & PSP_MEM_TRAIN_SEND_LONG_MSG) {
> /*
> - * Long traing will encroach certain mount of bottom VRAM,
> + * Long training will encroach certain mount of bottom VRAM,
amount
I think.
> * saving the content of this bottom VRAM to system memory
> * before training, and restoring it after training to avoid
> * VRAM corruption.
> --
> 2.26.2
>
--
~Randy
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] drm/amdgpu: Fix a typo
2021-03-18 18:07 ` Randy Dunlap
@ 2021-03-18 18:12 ` Alex Deucher
2021-03-18 20:25 ` Bhaskar Chowdhury
0 siblings, 1 reply; 8+ messages in thread
From: Alex Deucher @ 2021-03-18 18:12 UTC (permalink / raw)
To: Randy Dunlap
Cc: Bhaskar Chowdhury, Deucher, Alexander, Christian Koenig,
Dave Airlie, Daniel Vetter, Hawking Zhang, John Clements,
Chen, Guchun, Tao Zhou, Likun Gao, Bhawanpreet Lakha,
Jiansong Chen, Huang Rui, amd-gfx list,
Maling list - DRI developers, LKML
On Thu, Mar 18, 2021 at 2:08 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> On 3/18/21 4:33 AM, Bhaskar Chowdhury wrote:
> >
> > s/traing/training/
> >
> > Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> > ---
> > drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> > index c325d6f53a71..db18e4f6cf5f 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> > @@ -661,7 +661,7 @@ static int psp_v11_0_memory_training(struct psp_context *psp, uint32_t ops)
> >
> > if (ops & PSP_MEM_TRAIN_SEND_LONG_MSG) {
> > /*
> > - * Long traing will encroach certain mount of bottom VRAM,
> > + * Long training will encroach certain mount of bottom VRAM,
>
> amount
> I think.
Yeah, I think it should read something like:
Long training will encroach a certain amount on the bottom of VRAM;
save the content from the bottom VRAM to system memory
before training, and restore it after training to avoid
VRAM corruption.
Alex
>
> > * saving the content of this bottom VRAM to system memory
> > * before training, and restoring it after training to avoid
> > * VRAM corruption.
> > --
> > 2.26.2
> >
>
>
> --
> ~Randy
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] drm/amdgpu: Fix a typo
2021-03-18 18:12 ` Alex Deucher
@ 2021-03-18 20:25 ` Bhaskar Chowdhury
0 siblings, 0 replies; 8+ messages in thread
From: Bhaskar Chowdhury @ 2021-03-18 20:25 UTC (permalink / raw)
To: Alex Deucher
Cc: Randy Dunlap, Deucher, Alexander, Christian Koenig, Dave Airlie,
Daniel Vetter, Hawking Zhang, John Clements, Chen, Guchun,
Tao Zhou, Likun Gao, Bhawanpreet Lakha, Jiansong Chen, Huang Rui,
amd-gfx list, Maling list - DRI developers, LKML
[-- Attachment #1: Type: text/plain, Size: 1741 bytes --]
On 14:12 Thu 18 Mar 2021, Alex Deucher wrote:
>On Thu, Mar 18, 2021 at 2:08 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>>
>> On 3/18/21 4:33 AM, Bhaskar Chowdhury wrote:
>> >
>> > s/traing/training/
>> >
>> > Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
>> > ---
>> > drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
>> > index c325d6f53a71..db18e4f6cf5f 100644
>> > --- a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
>> > +++ b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
>> > @@ -661,7 +661,7 @@ static int psp_v11_0_memory_training(struct psp_context *psp, uint32_t ops)
>> >
>> > if (ops & PSP_MEM_TRAIN_SEND_LONG_MSG) {
>> > /*
>> > - * Long traing will encroach certain mount of bottom VRAM,
>> > + * Long training will encroach certain mount of bottom VRAM,
>>
>> amount
>> I think.
>
>Yeah, I think it should read something like:
>
>Long training will encroach a certain amount on the bottom of VRAM;
>save the content from the bottom VRAM to system memory
>before training, and restore it after training to avoid
>VRAM corruption.
>
>Alex
>
>>
>> > * saving the content of this bottom VRAM to system memory
>> > * before training, and restoring it after training to avoid
>> > * VRAM corruption.
Thanks.
>> > --
>> > 2.26.2
>> >
>>
>>
>> --
>> ~Randy
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] drm/amdgpu: Fix a typo
@ 2021-03-18 23:18 Bhaskar Chowdhury
2021-03-19 3:35 ` Alex Deucher
0 siblings, 1 reply; 8+ messages in thread
From: Bhaskar Chowdhury @ 2021-03-18 23:18 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel,
Hawking.Zhang, John.Clements, guchun.chen, tao.zhou1, Likun.Gao,
unixbhaskar, Bhawanpreet.Lakha, ray.huang, Jiansong.Chen, amd-gfx,
dri-devel, linux-kernel
Cc: rdunlap
s/proces/process/
Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
---
drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
index bf3857867f51..c1d5a3085bae 100644
--- a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
@@ -598,7 +598,7 @@ static int psp_v11_0_memory_training_send_msg(struct psp_context *psp, int msg)
}
/*
- * save and restore proces
+ * save and restore process
*/
static int psp_v11_0_memory_training(struct psp_context *psp, uint32_t ops)
{
--
2.26.2
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] drm/amdgpu: Fix a typo
2021-03-18 23:18 Bhaskar Chowdhury
@ 2021-03-19 3:35 ` Alex Deucher
0 siblings, 0 replies; 8+ messages in thread
From: Alex Deucher @ 2021-03-19 3:35 UTC (permalink / raw)
To: Bhaskar Chowdhury
Cc: Deucher, Alexander, Christian Koenig, Dave Airlie, Daniel Vetter,
Hawking Zhang, John Clements, Chen, Guchun, Tao Zhou, Likun Gao,
Bhawanpreet Lakha, Huang Rui, Jiansong Chen, amd-gfx list,
Maling list - DRI developers, LKML, Randy Dunlap
Applied both patches. Thanks!
Alex
On Thu, Mar 18, 2021 at 7:20 PM Bhaskar Chowdhury <unixbhaskar@gmail.com> wrote:
>
>
> s/proces/process/
>
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> ---
> drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> index bf3857867f51..c1d5a3085bae 100644
> --- a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> @@ -598,7 +598,7 @@ static int psp_v11_0_memory_training_send_msg(struct psp_context *psp, int msg)
> }
>
> /*
> - * save and restore proces
> + * save and restore process
> */
> static int psp_v11_0_memory_training(struct psp_context *psp, uint32_t ops)
> {
> --
> 2.26.2
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] drm/amdgpu: Fix a typo
@ 2024-09-09 22:41 Andrew Kreimer
2024-09-11 17:28 ` Alex Deucher
0 siblings, 1 reply; 8+ messages in thread
From: Andrew Kreimer @ 2024-09-09 22:41 UTC (permalink / raw)
To: Alex Deucher, Christian König, Xinhui Pan, David Airlie,
Simona Vetter, Hawking Zhang, Candice Li, Tao Zhou,
Stanley . Yang, Srinivasan Shanmugam, Yang Wang, Lijo Lazar
Cc: amd-gfx, dri-devel, linux-kernel, kernel-janitors, Andrew Kreimer,
Matthew Wilcox
Fix a typo in comments.
Reported-by: Matthew Wilcox <willy@infradead.org>
Signed-off-by: Andrew Kreimer <algonell@gmail.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c
index aab8077e5098..f28f6b4ba765 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c
@@ -58,7 +58,7 @@
#define EEPROM_I2C_MADDR_4 0x40000
/*
- * The 2 macros bellow represent the actual size in bytes that
+ * The 2 macros below represent the actual size in bytes that
* those entities occupy in the EEPROM memory.
* RAS_TABLE_RECORD_SIZE is different than sizeof(eeprom_table_record) which
* uses uint64 to store 6b fields such as retired_page.
--
2.46.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/amdgpu: Fix a typo
2024-09-09 22:41 Andrew Kreimer
@ 2024-09-11 17:28 ` Alex Deucher
0 siblings, 0 replies; 8+ messages in thread
From: Alex Deucher @ 2024-09-11 17:28 UTC (permalink / raw)
To: Andrew Kreimer
Cc: Alex Deucher, Christian König, Xinhui Pan, David Airlie,
Simona Vetter, Hawking Zhang, Candice Li, Tao Zhou,
Stanley . Yang, Srinivasan Shanmugam, Yang Wang, Lijo Lazar,
amd-gfx, dri-devel, linux-kernel, kernel-janitors, Matthew Wilcox
Applied. Thanks!
On Mon, Sep 9, 2024 at 6:53 PM Andrew Kreimer <algonell@gmail.com> wrote:
>
> Fix a typo in comments.
>
> Reported-by: Matthew Wilcox <willy@infradead.org>
> Signed-off-by: Andrew Kreimer <algonell@gmail.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c
> index aab8077e5098..f28f6b4ba765 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c
> @@ -58,7 +58,7 @@
> #define EEPROM_I2C_MADDR_4 0x40000
>
> /*
> - * The 2 macros bellow represent the actual size in bytes that
> + * The 2 macros below represent the actual size in bytes that
> * those entities occupy in the EEPROM memory.
> * RAS_TABLE_RECORD_SIZE is different than sizeof(eeprom_table_record) which
> * uses uint64 to store 6b fields such as retired_page.
> --
> 2.46.0
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2024-09-11 17:28 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-18 11:33 [PATCH] drm/amdgpu: Fix a typo Bhaskar Chowdhury
2021-03-18 18:07 ` Randy Dunlap
2021-03-18 18:12 ` Alex Deucher
2021-03-18 20:25 ` Bhaskar Chowdhury
-- strict thread matches above, loose matches on Subject: below --
2021-03-18 23:18 Bhaskar Chowdhury
2021-03-19 3:35 ` Alex Deucher
2024-09-09 22:41 Andrew Kreimer
2024-09-11 17:28 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox