From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B89B0C4332E for ; Thu, 18 Mar 2021 17:14:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8ECDA64F24 for ; Thu, 18 Mar 2021 17:14:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232250AbhCRRNp (ORCPT ); Thu, 18 Mar 2021 13:13:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33818 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232288AbhCRRNj (ORCPT ); Thu, 18 Mar 2021 13:13:39 -0400 Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9E11C061760 for ; Thu, 18 Mar 2021 10:13:38 -0700 (PDT) Received: by mail-pj1-x1035.google.com with SMTP id ha17so3273389pjb.2 for ; Thu, 18 Mar 2021 10:13:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=1sseX0Xf3BUtKz3PR0Gizm8Ulb+76kkvwxNlI1Phel0=; b=lPHk5Qo2Lb35CXcQnM+dRJ5QATTMsQuJnxyOV8yE5AlzOJe7G7CXoxkCB7ivQ1MHCq B0Dm0BhakKimujDv9ePNv9PH/WSAC/PW8M3GpTFZZTKsPwsBEPHQeT7nPFnN4GWCBNKC 6kDr0+TmcPqWTq4cnlMVj4fQ/ezN8uIhxFx9I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=1sseX0Xf3BUtKz3PR0Gizm8Ulb+76kkvwxNlI1Phel0=; b=sg2J1TKsSwDYghHzfQ5oqi6oT1lB2laIAf4+jsRUm1nFlLiXn9jV/wPbHhbm8wji00 SdCloHms25qHzq1di+1YYpgoaiUKQbWloav55XW0SMobwz35IvXYwVz/rEnWBiEb51Y6 Eg08Nn0oLgRYqtxpD8kOqv7UWM/5D2xzpUZ28aeeFgiSzdYWfYWkQG8uONS1YlxR6iKM MlNcjrv0HAvdbijqLinOahlplPR7H+VW5JFGO7mCpgcshklVLK0xUtJSiLeremzUhomx 4lIEnr/3dCi7/orllJ1nLQrgakq93sTYXIqUGfrHn902YYjIq+yNl3QMMbx6PCifK8CU Gs/A== X-Gm-Message-State: AOAM5303qKuKSUyUct3ENU6bxux7N86h0zuJ5W3aT2f7YKaFkTyihpuf bqXNCiAzYzLK0HgkdtrJX+yAt3n+Ezbr0A== X-Google-Smtp-Source: ABdhPJwbOEmo329XpSz1wEf3cFY6vA7M4NEYEfSU9e0kOD9VDn2EAXvUS6ECDxze8HrI66RfVx5BJA== X-Received: by 2002:a17:902:441:b029:e6:364a:5f55 with SMTP id 59-20020a1709020441b02900e6364a5f55mr10714521ple.7.1616087618263; Thu, 18 Mar 2021 10:13:38 -0700 (PDT) Received: from localhost ([2620:15c:202:1:3cf8:6a09:780b:f65d]) by smtp.gmail.com with UTF8SMTPSA id 21sm2666277pgf.69.2021.03.18.10.13.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Mar 2021 10:13:37 -0700 (PDT) Date: Thu, 18 Mar 2021 10:13:36 -0700 From: Matthias Kaehlcke To: Roja Rani Yarubandi Cc: agross@kernel.org, bjorn.andersson@linaro.org, gregkh@linuxfoundation.org, robh+dt@kernel.org, linux-serial@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rajendra Nayak , akashast@codeaurora.org, msavaliy@qti.qualcomm.com Subject: Re: [PATCH V2 1/2] soc: qcom-geni-se: Cleanup the code to remove proxy votes Message-ID: References: <20210318111009.30365-1-rojay@codeaurora.org> <20210318111009.30365-2-rojay@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210318111009.30365-2-rojay@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 18, 2021 at 04:40:08PM +0530, Roja Rani Yarubandi wrote: > ICC core and platforms drivers supports sync_state feature, which > ensures that the default ICC BW votes from the bootloader is not > removed until all it's consumers are probes. > > The proxy votes were needed in case other QUP child drivers > I2C, SPI probes before UART, they can turn off the QUP-CORE clock > which is shared resources for all QUP driver, this causes unclocked > access to HW from earlycon. > > Given above support from ICC there is no longer need to maintain > proxy votes on QUP-CORE ICC node from QUP wrapper driver for early > console usecase, the default votes won't be removed until real > console is probed. > > Signed-off-by: Roja Rani Yarubandi > Signed-off-by: Akash Asthana I suggest to mention that this is essentially a revert of commit 048eb908a1f2 ("soc: qcom-geni-se: Add interconnect support to fix earlycon crash"). This makes the life of reviewers easier and it's also good to have the reference in the git history. You could also mention commit 7d3b0b0d8184 ("interconnect: qcom: Use icc_sync_state") in the intro. I tried to test by first reproducing the original issue without 'sync_state' in the ICC, but wasn't successful, probably something changed in the boot/ICC timing in the meantime ¯\_(ツ)_/¯. Reviewed-by: Matthias Kaehlcke