From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 538D0C433E0 for ; Fri, 19 Mar 2021 13:48:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 26E8364F18 for ; Fri, 19 Mar 2021 13:48:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229990AbhCSNr5 (ORCPT ); Fri, 19 Mar 2021 09:47:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:52196 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229866AbhCSNrr (ORCPT ); Fri, 19 Mar 2021 09:47:47 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 116B464EEE; Fri, 19 Mar 2021 13:47:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1616161667; bh=hEfaNvDeQRC+DdyeCwn/ZVt7kmSSXJFmb0aCVkI39h8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=z3L77dQqHlXpG1l6/gS4TZeeZPmDrPZGaS8pwvTw3S8xWXV76/dcHkKp0XnrpN4zS LuorjNU5I+kEI1B3VowU0wrfdHW2hMQ34OTWH87OVCzkb+C73hZzSY+D4f2MqyMvco gVvcE/BNLl3rqU9kd6A+US/Rtt8HCFejYAnawiAQ= Date: Fri, 19 Mar 2021 14:47:45 +0100 From: Greg Kroah-Hartman To: Dmitry Osipenko Cc: Minchan Kim , Andrew Morton , linux-mm , LKML , joaodias@google.com, willy@infradead.org, david@redhat.com, surenb@google.com, John Hubbard , Nicolas Chauvet , "linux-tegra@vger.kernel.org" Subject: Re: [PATCH v4] mm: cma: support sysfs Message-ID: References: <20210309062333.3216138-1-minchan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 19, 2021 at 04:45:21PM +0300, Dmitry Osipenko wrote: > 19.03.2021 16:42, Greg Kroah-Hartman пишет: > > On Fri, Mar 19, 2021 at 04:39:41PM +0300, Dmitry Osipenko wrote: > >> 19.03.2021 15:44, Dmitry Osipenko пишет: > >> ... > >>>> #include > >>>> +#include > >>>> + > >>>> +struct cma_stat { > >>>> + spinlock_t lock; > >>>> + /* the number of CMA page successful allocations */ > >>>> + unsigned long nr_pages_succeeded; > >>>> + /* the number of CMA page allocation failures */ > >>>> + unsigned long nr_pages_failed; > >>>> + struct kobject kobj; > >>>> +}; > >>>> > >>>> struct cma { > >>>> unsigned long base_pfn; > >>>> @@ -16,6 +26,9 @@ struct cma { > >>>> struct debugfs_u32_array dfs_bitmap; > >>>> #endif > >>>> char name[CMA_MAX_NAME]; > >>>> +#ifdef CONFIG_CMA_SYSFS > >>>> + struct cma_stat *stat; > >>>> +#endif > >> > >> What is the point of allocating stat dynamically? > > > > Because static kobjects make me cry. > > > > I meant that it's already a part of struct cma, it looks like the stat > could be embedded into struct cma and then kobj could be initialized > separately. But that structure is statically allocated, so it can not be. This has been discussed in the past threads for when this was reviewed if you are curious :) thanks, greg k-h