From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F0D5C433DB for ; Sat, 20 Mar 2021 00:22:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E939D61981 for ; Sat, 20 Mar 2021 00:22:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229638AbhCTAVl (ORCPT ); Fri, 19 Mar 2021 20:21:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229564AbhCTAVk (ORCPT ); Fri, 19 Mar 2021 20:21:40 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82AF1C061760 for ; Fri, 19 Mar 2021 17:21:39 -0700 (PDT) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 236598D3; Sat, 20 Mar 2021 01:21:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1616199695; bh=YxyYG0rUzewpkZSqO4W7En5pkRKvoNodFD5mlHd1GTk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=d7IhFfS2Lv6sm+CBEt1QwgBC8BEsPfNz4YumUCf5tRZ8+by6MAIe0sVm92jSPtaNX lL2HCvxfBPZ+fz076pYKZ7nBlZfx6R8xUYp/Ec1dXOsS7MCOPuErg0tLU+d50Upz1a p8qQWdOpRX8/WbMPUQ31l4x9DadCoxbOo0Ia8c+A= Date: Sat, 20 Mar 2021 02:20:56 +0200 From: Laurent Pinchart To: Maxime Ripard Cc: dri-devel@lists.freedesktop.org, Daniel Vetter , David Airlie , Maarten Lankhorst , Thomas Zimmermann , Daniel Vetter , Heiko =?utf-8?Q?St=C3=BCbner?= , Sandy Huang , linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Stephen Rothwell Subject: Re: [PATCH] drm/rockchip: Remove unused variable Message-ID: References: <20210319152920.262035-1-maxime@cerno.tech> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210319152920.262035-1-maxime@cerno.tech> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Maxime, Thank you for the patch. On Fri, Mar 19, 2021 at 04:29:20PM +0100, Maxime Ripard wrote: > Commit 977697e20b3d ("drm/atomic: Pass the full state to planes atomic > disable and update") added the old_state variable instead of what used > to be a parameter, but it also removed the sole user of that variable in > the vop_plane_atomic_update function leading to an usused variable. > Remove it. > > Fixes: 977697e20b3d ("drm/atomic: Pass the full state to planes atomic disable and update") > Reported-by: Stephen Rothwell > Signed-off-by: Maxime Ripard Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > index 81c70d7a0471..64469439ddf2 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > @@ -879,8 +879,6 @@ static void vop_plane_atomic_disable(struct drm_plane *plane, > static void vop_plane_atomic_update(struct drm_plane *plane, > struct drm_atomic_state *state) > { > - struct drm_plane_state *old_state = drm_atomic_get_old_plane_state(state, > - plane); > struct drm_plane_state *new_state = drm_atomic_get_new_plane_state(state, > plane); > struct drm_crtc *crtc = new_state->crtc; -- Regards, Laurent Pinchart