From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25FFAC433DB for ; Sun, 21 Mar 2021 12:02:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E1E2761937 for ; Sun, 21 Mar 2021 12:02:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229897AbhCUMBp (ORCPT ); Sun, 21 Mar 2021 08:01:45 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:53038 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229815AbhCUMBU (ORCPT ); Sun, 21 Mar 2021 08:01:20 -0400 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id AB9806EF; Sun, 21 Mar 2021 13:01:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1616328077; bh=uQPPcJrUWiDnFYI/0TmpYQ30SpOmt42O1YYziYPGS5I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gXy+qJIBEtJKf3TNhvRwWvjBf46zHFbguuExd643koDTmpiopv294YiW5mk4n+n0R hGUrXQ09cfzImL7ZuQnb6jFBPaounN73se/jZJN70ifDG7asFCSZiep8DlTo42X0GS CPQPnohxNwgt5R4lNrvOiVU3+k1MBJEPzTnq5A8g= Date: Sun, 21 Mar 2021 14:00:38 +0200 From: Laurent Pinchart To: Xin Ji Cc: Rob Herring , David Airlie , Nicolas Boichat , Hsin-Yi Wang , Daniel Vetter , Sam Ravnborg , Maxime Ripard , Mark Brown , Ricardo =?utf-8?Q?Ca=C3=B1uelo?= , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, Bernie Liang , Sheng Pan , Zhen Li , linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 1/5] dt-bindings:drm/bridge:anx7625:add vendor define flags Message-ID: References: <4b09b40ce53c5b5fe7d2ba65a3c7a1b23f6eec04.1616135353.git.xji@analogixsemi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <4b09b40ce53c5b5fe7d2ba65a3c7a1b23f6eec04.1616135353.git.xji@analogixsemi.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Xin, Thank you for the patch. On Fri, Mar 19, 2021 at 02:32:39PM +0800, Xin Ji wrote: > Add 'bus-type' and 'data-lanes' define for port0. Define DP tx lane0, > lane1 swing register array define, and audio enable flag. > > Signed-off-by: Xin Ji > --- > .../display/bridge/analogix,anx7625.yaml | 58 ++++++++++++++++++- > 1 file changed, 57 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > index c789784efe30..3f54d5876982 100644 > --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > @@ -34,6 +34,26 @@ properties: > description: used for reset chip control, RESET_N pin B7. > maxItems: 1 > > + analogix,lane0-swing: > + $ref: /schemas/types.yaml#/definitions/uint32-array > + minItems: 1 > + maxItems: 20 > + description: > + an array of swing register setting for DP tx lane0 PHY, please don't > + add this property, or contact vendor. DT properties need to be documented. Contacting the vendor doesn't count as documentation I'm afraid. > + > + analogix,lane1-swing: > + $ref: /schemas/types.yaml#/definitions/uint32-array > + minItems: 1 > + maxItems: 20 > + description: > + an array of swing register setting for DP tx lane1 PHY, please don't > + add this property, or contact vendor. > + > + analogix,audio-enable: > + type: boolean > + description: let the driver enable audio HDMI codec function or not. > + > ports: > $ref: /schemas/graph.yaml#/properties/ports > > @@ -41,13 +61,43 @@ properties: > port@0: > $ref: /schemas/graph.yaml#/properties/port > description: > - Video port for MIPI DSI input. > + MIPI DSI/DPI input. > + > + properties: > + endpoint: > + $ref: /schemas/media/video-interfaces.yaml# > + type: object > + additionalProperties: false > + > + properties: > + remote-endpoint: true > + bus-type: true > + data-lanes: true > + > + required: > + - remote-endpoint > + > + required: > + - endpoint > + > > port@1: > $ref: /schemas/graph.yaml#/properties/port > description: > Video port for panel or connector. > > + properties: > + endpoint: > + $ref: /schemas/media/video-interfaces.yaml# > + type: object > + additionalProperties: false > + > + properties: > + remote-endpoint: true > + > + required: > + - remote-endpoint > + > required: > - port@0 > - port@1 > @@ -73,6 +123,10 @@ examples: > enable-gpios = <&pio 45 GPIO_ACTIVE_HIGH>; > reset-gpios = <&pio 73 GPIO_ACTIVE_HIGH>; > > + analogix,audio-enable; > + analogix,lane0-swing = <0x14 0x54 0x64 0x74 0x29 0x7b 0x77 0x5b>; > + analogix,lane1-swing = <0x14 0x54 0x64 0x74 0x29 0x7b 0x77 0x5b>; > + > ports { > #address-cells = <1>; > #size-cells = <0>; > @@ -81,6 +135,8 @@ examples: > reg = <0>; > anx7625_in: endpoint { > remote-endpoint = <&mipi_dsi>; > + bus-type = <5>; > + data-lanes = <0 1 2 3>; > }; > }; > -- Regards, Laurent Pinchart