Re: [RFC PATCH 5/8] hugetlb: change free_pool_huge_page to remove_pool_huge_page

Michal Hocko
2021-03-24T08:41:35Z

On Tue 23-03-21 18:03:07, Mike Kravetz wrote:
[...]
> Since you brought up cgroups ... what is your opinion on lock hold time
> in hugetlb_cgroup_css_offline? We could potentially be calling
> hugetlb_cgroup_move_parent for every hugetlb page while holding the lock
> with interrupts disabled.

I am not familiar with hugetlb cgroup code TBH. But from a quick look
there is not much of heavy lifting there. If we find out that this is
really visible we can do the lock dance with cond_resched and retry with
the iteration again. Or is there any strong reason to process the list
in a single go?
--
Michal Hocko
SUSE Labs