Re: [RFC PATCH 2/8] hugetlb: recompute min_count when dropping hugetlb_lock

Michal Hocko
2021-03-24T08:37:11Z

On Tue 23-03-21 16:18:08, Mike Kravetz wrote:
[...]
> Here is another thought.
> In patch 5 you suggest removing all pages from hugetlb with the lock
> held, and adding them to a list. Then, drop the lock and free all
> pages on the list. If we do this, then the value computed here (min_count)
> can not change while we are looping. So, this patch would be unnecessary.
> That is another argument in favor of batching the frees.
>
> Unless there is something wrong in my thinking, I am going to take that
> approach and drop this patch.

Makes sense
--
Michal Hocko
SUSE Labs