From: Matthias Kaehlcke <mka@chromium.org>
To: skakit@codeaurora.org
Cc: Rob Herring <robh+dt@kernel.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, kgunda@codeaurora.org
Subject: Re: [PATCH] arm64: dts: qcom: sc7280: Add PMIC peripherals for SC7280
Date: Mon, 22 Mar 2021 10:34:10 -0700 [thread overview]
Message-ID: <YFjVEjcx36J97hVW@google.com> (raw)
In-Reply-To: <4dc784eb3c00a9805141148732476838@codeaurora.org>
Hi Satya,
On Mon, Mar 22, 2021 at 06:50:47PM +0530, skakit@codeaurora.org wrote:
> Hi Matthias,
>
> On 2021-03-13 02:10, Matthias Kaehlcke wrote:
> > Hi Satya,
> >
> > On Thu, Mar 11, 2021 at 04:10:29PM +0530, satya priya wrote:
> > > Add PM7325/PM8350C/PMK8350/PMR735A peripherals such as PON,
> > > GPIOs, RTC and other PMIC infra modules for SC7280.
> > >
> > > Signed-off-by: satya priya <skakit@codeaurora.org>
> > > ---
> > > This patch depends on base DT and board files for SC7280 to merge
> > > first
> > > https://lore.kernel.org/patchwork/project/lkml/list/?series=487403
> > >
> > > arch/arm64/boot/dts/qcom/pm7325.dtsi | 60 ++++++++++++++++++++
> > > arch/arm64/boot/dts/qcom/pm8350c.dtsi | 60 ++++++++++++++++++++
> > > arch/arm64/boot/dts/qcom/pmk8350.dtsi | 104
> > > ++++++++++++++++++++++++++++++++++
> > > arch/arm64/boot/dts/qcom/pmr735a.dtsi | 60 ++++++++++++++++++++
> > > arch/arm64/boot/dts/qcom/sc7280.dtsi | 8 +++
> > > 5 files changed, 292 insertions(+)
> > > create mode 100644 arch/arm64/boot/dts/qcom/pm7325.dtsi
> > > create mode 100644 arch/arm64/boot/dts/qcom/pm8350c.dtsi
> > > create mode 100644 arch/arm64/boot/dts/qcom/pmk8350.dtsi
> > > create mode 100644 arch/arm64/boot/dts/qcom/pmr735a.dtsi
> > >
> > > diff --git a/arch/arm64/boot/dts/qcom/pm7325.dtsi
> > > b/arch/arm64/boot/dts/qcom/pm7325.dtsi
> > > new file mode 100644
> > > index 0000000..393b256
> > > --- /dev/null
> > > +++ b/arch/arm64/boot/dts/qcom/pm7325.dtsi
> > > @@ -0,0 +1,60 @@
> >
> > ...
> >
> > > + polling-delay-passive = <100>;
> > > + polling-delay = <0>;
> >
> > Are you sure that no polling delay is needed? How does the thermal
> > framework
> > detect that the temperatures is >= the passive trip point and that it
> > should
> > start polling at 'polling-delay-passive' rate?
> >
>
> As the temp-alarm has interrupt support, whenever preconfigured threshold
> violates it notifies thermal framework, so I think the polling delay is not
> needed here.
From the documentation I found it's not clear to me how exactly these
interrupts work. Is a single interrupt triggered when the threshold is
violated or are there periodic (?) interrupts as long as the temperature
is above the stage 0 threshold?
Why is 'polling-delay-passive' passive needed if there are interrupts? Maybe
to detect that the zone should transition from passive to no cooling when the
temperature drops below the stage 0 threshold?
next prev parent reply other threads:[~2021-03-22 17:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 10:40 [PATCH] arm64: dts: qcom: sc7280: Add PMIC peripherals for SC7280 satya priya
2021-03-12 17:36 ` Bjorn Andersson
2021-03-22 13:18 ` skakit
2021-03-12 20:40 ` Matthias Kaehlcke
2021-03-22 13:20 ` skakit
2021-03-22 17:34 ` Matthias Kaehlcke [this message]
2021-03-25 5:20 ` skakit
2021-03-30 18:19 ` Matthias Kaehlcke
2021-03-12 20:47 ` Matthias Kaehlcke
2021-03-22 14:05 ` skakit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFjVEjcx36J97hVW@google.com \
--to=mka@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kgunda@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=skakit@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox