RE: [PATCH 2/5] cifsd: add server-side procedures for SMB3

Namjae Jeon
2021-03-22T23:21:05Z

> On Mon, Mar 22, 2021 at 09:47:13AM +0300, Dan Carpenter wrote:
> > On Mon, Mar 22, 2021 at 02:13:41PM +0900, Namjae Jeon wrote:
> > > +static unsigned char
> > > +asn1_octet_decode(struct asn1_ctx *ctx, unsigned char *ch) {
> > > + if (ctx->pointer >= ctx->end) {
> > > + ctx->error = ASN1_ERR_DEC_EMPTY;
> > > + return 0;
> > > + }
> > > + *ch = *(ctx->pointer)++;
> > > + return 1;
> > > +}
> >
> >
> > Make this bool.
> >
>
> More importantly don't add another ANS1 parser, but use the generic one in lib/asn1_decoder.c instead.
> CIFS should also really use it.
Okay, Let me check it, cifs also...
Thanks!