RE: [PATCH 1/5] cifsd: add server handler and tranport layers

Namjae Jeon
2021-03-23T03:16:57Z

> On Tue, Mar 23, 2021 at 12:01:22PM +0900, Namjae Jeon wrote:
> > > On Mon, Mar 22, 2021 at 02:13:40PM +0900, Namjae Jeon wrote:
> > > > +#define RESPONSE_BUF(w) ((void *)(w)->response_buf)
> > > > +#define REQUEST_BUF(w) ((void *)(w)->request_buf)
> > >
> > > Why do you do this obfuscation?
> > I don't remember exactly, but back then, It looked easier...
> > >
> > > > +#define RESPONSE_BUF_NEXT(w) \
> > > > + ((void *)((w)->response_buf + (w)->next_smb2_rsp_hdr_off))
> > > > +#define REQUEST_BUF_NEXT(w) \
> > > > + ((void *)((w)->request_buf + (w)->next_smb2_rcv_hdr_off))
> > >
> > > These obfuscations aren't even used; delete them
> > They are used in many place.
>
> Oh, argh. patch 2/5 was too big, so it didn't make it into the mailing list archive I was using to
> try to review this series. Please break it up into smaller pieces for next time!
Okay:)
Thanks!