From: Greg KH <gregkh@linuxfoundation.org>
To: Luiz Sampaio <sampaio.ime@gmail.com>
Cc: zbr@ioremap.net, rikard.falkeborn@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] w1: ds2438: adding support for accessing page1 registers
Date: Tue, 23 Mar 2021 10:42:32 +0100 [thread overview]
Message-ID: <YFm4CAvBcT3MN87T@kroah.com> (raw)
In-Reply-To: <20210323024410.temxutbcfdswctz4@LuizSampaio-PC.localdomain>
On Mon, Mar 22, 2021 at 11:44:10PM -0300, Luiz Sampaio wrote:
> @@ -395,6 +483,8 @@ static BIN_ATTR_RO(vdd, 0/* real length varies */);
> static struct bin_attribute *w1_ds2438_bin_attrs[] = {
> &bin_attr_iad,
> &bin_attr_page0,
> + &bin_attr_page1,
> + &bin_attr_offset,
You are adding new sysfs files, but no new Documentation/ABI entries :(
please fix that up for your next submission.
thanks,
greg k-h
prev parent reply other threads:[~2021-03-23 9:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 2:44 [PATCH 3/3] w1: ds2438: adding support for accessing page1 registers Luiz Sampaio
2021-03-23 9:42 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFm4CAvBcT3MN87T@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rikard.falkeborn@gmail.com \
--cc=sampaio.ime@gmail.com \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox