From: Greg KH <gregkh@linuxfoundation.org>
To: Shubhankar Kuranagatti <shubhankarvk@gmail.com>
Cc: jason.wessel@windriver.com, dianders@chromium.org, arnd@arndb.de,
kgdb-bugreport@lists.sourceforge.net,
linux-kernel@vger.kernel.org, bkkarthik@pesu.pes.edu
Subject: Re: [PATCH 1/2] drivers: misc: kgdbts.c: Fix declaration warning.
Date: Tue, 23 Mar 2021 13:54:24 +0100 [thread overview]
Message-ID: <YFnlADClpqE9Zkom@kroah.com> (raw)
In-Reply-To: <20210313215808.dt7uvt2suwq4z4x3@kewl-virtual-machine>
On Sun, Mar 14, 2021 at 03:28:08AM +0530, Shubhankar Kuranagatti wrote:
> A new line has been added after declaration. This is done to
> maintain code uniformity.
>
> Signed-off-by: Shubhankar Kuranagatti <shubhankarvk@gmail.com>
> ---
> drivers/misc/kgdbts.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/misc/kgdbts.c b/drivers/misc/kgdbts.c
> index 945701bce553..3ee5acc1c391 100644
> --- a/drivers/misc/kgdbts.c
> +++ b/drivers/misc/kgdbts.c
> @@ -474,6 +474,7 @@ static int emul_sstep_put(char *put_str, char *arg)
> {
> if (!arch_needs_sstep_emulation) {
> char *ptr = &put_str[11];
> +
> if (put_str[1] != 'T' || put_str[2] != '0')
> return 1;
> kgdb_hex2long(&ptr, &sstep_thread_id);
> @@ -502,6 +503,7 @@ static int emul_sstep_put(char *put_str, char *arg)
> return 1;
> } else {
> char *ptr = &put_str[11];
> +
> kgdb_hex2long(&ptr, &sstep_thread_id);
> }
> break;
> @@ -740,6 +742,7 @@ static int validate_simple_test(char *put_str)
> static int run_simple_test(int is_get_char, int chr)
> {
> int ret = 0;
> +
> if (is_get_char) {
> /* Send an ACK on the get if a prior put completed and set the * send ack variable
> --
> 2.17.1
This patch is corrupted :(
Please fix up and resend the whole series properly threaded so our tools
can pick them both up at the same time.
thanks,
greg k-h
prev parent reply other threads:[~2021-03-23 12:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-13 21:58 [PATCH 1/2] drivers: misc: kgdbts.c: Fix declaration warning Shubhankar Kuranagatti
2021-03-23 12:54 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFnlADClpqE9Zkom@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=bkkarthik@pesu.pes.edu \
--cc=dianders@chromium.org \
--cc=jason.wessel@windriver.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=shubhankarvk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox