From: Greg KH <gregkh@linuxfoundation.org>
To: Abhishek C <astro.abhishek02@gmail.com>
Cc: devel@driverdev.osuosl.org, tkjos@android.com, surenb@google.com,
bkkarthik@pesu.pes.edu, linux-kernel@vger.kernel.org,
hridya@google.com, arve@android.com, joel@joelfernandes.org,
maco@android.com, christian@brauner.io
Subject: Re: [PATCH] drivers: android: binder.c: Fix indentation of multi-line comment
Date: Tue, 23 Mar 2021 14:18:51 +0100 [thread overview]
Message-ID: <YFnqu9b20whmRJNh@kroah.com> (raw)
In-Reply-To: <20210313161655.mu64qezxog4ghibq@astroabhi>
On Sat, Mar 13, 2021 at 09:46:55PM +0530, Abhishek C wrote:
> Fixed alignment of multi-line comment.
> Added a * for each line of the comment.
>
> Signed-off-by: Abhishek C <astro.abhishek02@gmail.com>
> ---
> drivers/android/binder.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/android/binder.c b/drivers/android/binder.c
> index c119736ca56a..700719c58147 100644
> --- a/drivers/android/binder.c
> +++ b/drivers/android/binder.c
> @@ -4617,8 +4617,9 @@ static long binder_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
> unsigned int size = _IOC_SIZE(cmd);
> void __user *ubuf = (void __user *)arg;
>
> - /*pr_info("binder_ioctl: %d:%d %x %lx\n",
> - proc->pid, current->pid, cmd, arg);*/
> + /* pr_info("binder_ioctl: %d:%d %x %lx\n",
> + * proc->pid, current->pid, cmd, arg);
> + */
This looks like left-over debugging code, and as-is, is formatted
properly.
Why not just delete it entirely? If someone needs debugging code, they
can add it back in.
thanks,
greg k-h
prev parent reply other threads:[~2021-03-23 13:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-13 16:16 [PATCH] drivers: android: binder.c: Fix indentation of multi-line comment Abhishek C
2021-03-23 13:18 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFnqu9b20whmRJNh@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arve@android.com \
--cc=astro.abhishek02@gmail.com \
--cc=bkkarthik@pesu.pes.edu \
--cc=christian@brauner.io \
--cc=devel@driverdev.osuosl.org \
--cc=hridya@google.com \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=surenb@google.com \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox