Re: [PATCH 1/3] tty: serial: Add UART driver for Cortina-Access platform

Greg Kroah-Hartman
2021-03-23T09:23:44Z

On Thu, Feb 18, 2021 at 06:42:09PM -0800, Alex Nemirovsky wrote:
> From: Jason Li <jason.li@cortina-access.com>
>
> This driver supports Cortina Access UART IP integrated
> in most all CAXXXX line of SoCs. Earlycom is also supported
>
> Signed-off-by: Jason Li <jason.li@cortina-access.com>
> Reviewed-by: Alex Nemirovsky <alex.nemirovsky@cortina-access.com>
> ---
> MAINTAINERS | 5 +
> drivers/tty/serial/Kconfig | 19 +
> drivers/tty/serial/Makefile | 1 +
> drivers/tty/serial/serial_cortina-access.c | 798 +++++++++++++++++++++++++++++
> include/uapi/linux/serial_core.h | 3 +
> 5 files changed, 826 insertions(+)
> create mode 100644 drivers/tty/serial/serial_cortina-access.c
>
> Change log
> drivers/tty/serial/serial_cortina-access.c
> v3:
> - Remove usage of uintptr_t. Change to pointer to driver's private
> structure instead.

Is this really a "v3"? The subject lines do not show that, so I'm
totally confused as to what to review and what has been reviewed here.

Please fix this up and submit a "v4" so we know what is going on :)

thanks,

greg k-h