From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
Alexei Starovoitov <ast@kernel.org>, Jessica Yu <jeyu@kernel.org>,
Evan Green <evgreen@chromium.org>,
Hsin-Yi Wang <hsinyi@chromium.org>,
Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH v2 03/12] dump_stack: Add vmlinux build ID to stack traces
Date: Wed, 24 Mar 2021 13:22:58 +0200 [thread overview]
Message-ID: <YFshElW7XI+ekhfy@smile.fi.intel.com> (raw)
In-Reply-To: <20210324020443.1815557-4-swboyd@chromium.org>
On Tue, Mar 23, 2021 at 07:04:34PM -0700, Stephen Boyd wrote:
> Add the running kernel's build ID[1] to the stacktrace information
> header. This makes it simpler for developers to locate the vmlinux with
> full debuginfo for a particular kernel stacktrace. Combined with
> scripts/decode_stracktrace.sh, a developer can download the correct
> vmlinux from a debuginfod[2] server and find the exact file and line
> number for the functions plus offsets in a stacktrace.
>
> This is especially useful for pstore crash debugging where the kernel
> crashes are recorded in the pstore logs and the recovery kernel is
> different or the debuginfo doesn't exist on the device due to space
> concerns (the data can be large and a security concern). The stacktrace
> can be analyzed after the crash by using the build ID to find the
> matching vmlinux and understand where in the function something went
> wrong.
>
> Example stacktrace from lkdtm:
Can we drop the noise from the example and leave only important part(s)?
> WARNING: CPU: 4 PID: 3255 at drivers/misc/lkdtm/bugs.c:83 lkdtm_WARNING+0x28/0x30 [lkdtm]
> Modules linked in: lkdtm rfcomm algif_hash algif_skcipher af_alg xt_cgroup uinput xt_MASQUERADE
> CPU: 4 PID: 3255 Comm: bash Not tainted 5.11 #3 aa23f7a1231c229de205662d5a9e0d4c580f19a1
> Hardware name: Google Lazor (rev3+) with KB Backlight (DT)
> pstate: 00400009 (nzcv daif +PAN -UAO -TCO BTYPE=--)
> pc : lkdtm_WARNING+0x28/0x30 [lkdtm]
> lr : lkdtm_do_action+0x24/0x40 [lkdtm]
> sp : ffffffc0134fbca0
> x29: ffffffc0134fbca0 x28: ffffff92d53ba240
> x27: 0000000000000000 x26: 0000000000000000
> x25: 0000000000000000 x24: ffffffe3622352c0
> x23: 0000000000000020 x22: ffffffe362233366
> x21: ffffffe3622352e0 x20: ffffffc0134fbde0
> x19: 0000000000000008 x18: 0000000000000000
> x17: ffffff929b6536fc x16: 0000000000000000
> x15: 0000000000000000 x14: 0000000000000012
> x13: ffffffe380ed892c x12: ffffffe381d05068
> x11: 0000000000000000 x10: 0000000000000000
> x9 : 0000000000000001 x8 : ffffffe362237000
> x7 : aaaaaaaaaaaaaaaa x6 : 0000000000000000
> x5 : 0000000000000000 x4 : 0000000000000001
> x3 : 0000000000000008 x2 : ffffff93fef25a70
> x1 : ffffff93fef15788 x0 : ffffffe3622352e0
> Call trace:
> lkdtm_WARNING+0x28/0x30 [lkdtm]
> direct_entry+0x16c/0x1b4 [lkdtm]
> full_proxy_write+0x74/0xa4
> vfs_write+0xec/0x2e8
> ksys_write+0x84/0xf0
> __arm64_sys_write+0x24/0x30
> el0_svc_common+0xf4/0x1c0
> do_el0_svc_compat+0x28/0x3c
> el0_svc_compat+0x10/0x1c
> el0_sync_compat_handler+0xa8/0xcc
> el0_sync_compat+0x178/0x180
> ---[ end trace 3d95032303e59e68 ]---
>
> The hex string aa23f7a1231c229de205662d5a9e0d4c580f19a1 is the build ID,
> following the kernel version number.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-03-24 11:23 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 2:04 [PATCH v2 00/12] Add build ID to stacktraces Stephen Boyd
2021-03-24 2:04 ` [PATCH v2 01/12] buildid: Add API to parse build ID out of buffer Stephen Boyd
2021-03-24 2:04 ` [PATCH v2 02/12] buildid: Add method to get running kernel's build ID Stephen Boyd
2021-03-24 9:24 ` Rasmus Villemoes
2021-03-24 19:06 ` Stephen Boyd
2021-03-24 2:04 ` [PATCH v2 03/12] dump_stack: Add vmlinux build ID to stack traces Stephen Boyd
2021-03-24 11:22 ` Andy Shevchenko [this message]
2021-03-24 19:01 ` Stephen Boyd
2021-03-24 2:04 ` [PATCH v2 04/12] module: Add printk format to add module build ID to stacktraces Stephen Boyd
2021-03-24 9:57 ` Rasmus Villemoes
2021-03-24 19:11 ` Stephen Boyd
2021-03-24 22:21 ` Rasmus Villemoes
2021-03-24 22:28 ` Stephen Boyd
2021-03-30 10:51 ` Petr Mladek
2021-03-30 10:29 ` Petr Mladek
2021-03-30 19:12 ` Stephen Boyd
2021-03-24 2:04 ` [PATCH v2 05/12] arm64: stacktrace: Use %pSb for backtrace printing Stephen Boyd
2021-03-24 2:04 ` [PATCH v2 06/12] x86/dumpstack: " Stephen Boyd
2021-03-24 2:04 ` [PATCH v2 07/12] scripts/decode_stacktrace.sh: Support debuginfod Stephen Boyd
2021-03-24 11:27 ` Andy Shevchenko
2021-03-24 22:22 ` Stephen Boyd
2021-03-24 2:04 ` [PATCH v2 08/12] scripts/decode_stacktrace.sh: Silence stderr messages from addr2line/nm Stephen Boyd
2021-03-24 2:04 ` [PATCH v2 09/12] scripts/decode_stacktrace.sh: Indicate 'auto' can be used for base path Stephen Boyd
2021-03-24 2:04 ` [PATCH v2 10/12] buildid: Mark some arguments const Stephen Boyd
2021-03-24 2:04 ` [PATCH v2 11/12] buildid: Fix kernel-doc notation Stephen Boyd
2021-03-24 2:04 ` [PATCH v2 12/12] kdump: Use vmlinux_build_id() to simplify Stephen Boyd
2021-03-24 8:55 ` [PATCH v2 00/12] Add build ID to stacktraces Christoph Hellwig
2021-03-25 11:06 ` peter enderborg
2021-03-25 23:21 ` Stephen Boyd
2021-03-30 10:59 ` Petr Mladek
[not found] ` <32011616573677@mail.yandex-team.ru>
2021-03-24 19:04 ` Stephen Boyd
2021-03-25 11:14 ` peter enderborg
2021-03-25 23:18 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFshElW7XI+ekhfy@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=ast@kernel.org \
--cc=evgreen@chromium.org \
--cc=hsinyi@chromium.org \
--cc=jeyu@kernel.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=swboyd@chromium.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox