Re: [PATCH v2 2/2] intel/pinctrl: check capability offset is between MMIO region

Andy Shevchenko
2021-03-24T17:03:12Z

On Wed, Mar 24, 2021 at 04:43:12PM +0100, Roger Pau Monne wrote:
> When parsing the capability list make sure the offset is between the
> MMIO region mapped in 'regs', or else the kernel hits a page fault.
>
> Adding the check is harmless, and prevents buggy or broken systems
> from crashing the kernel if the capability linked list is somehow
> broken.

I don't think we need a dead code in the kernel. If you have a hardware to show
this issue, I eagerly want to know this!

--
With Best Regards,
Andy Shevchenko