From: Bhaskar Chowdhury <unixbhaskar@gmail.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: alexander.deucher@amd.com, christian.koenig@amd.com,
airlied@linux.ie, daniel@ffwll.ch, amd-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/radeon/r600_cs: Couple of typo fixes
Date: Thu, 25 Mar 2021 05:00:39 +0530 [thread overview]
Message-ID: <YFvLn0E+9AaqLY0e@Slackware> (raw)
In-Reply-To: <e3c60b65-7df2-18d8-4275-3588f6777810@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 1549 bytes --]
On 14:48 Wed 24 Mar 2021, Randy Dunlap wrote:
>On 3/24/21 6:50 AM, Bhaskar Chowdhury wrote:
>>
>> s/miror/mirror/
>> s/needind/needing/
>>
>> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
>> ---
>> drivers/gpu/drm/radeon/r600_cs.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/radeon/r600_cs.c b/drivers/gpu/drm/radeon/r600_cs.c
>> index 34b7c6f16479..aded1f2264e0 100644
>> --- a/drivers/gpu/drm/radeon/r600_cs.c
>> +++ b/drivers/gpu/drm/radeon/r600_cs.c
>> @@ -38,7 +38,7 @@ extern void r600_cs_legacy_get_tiling_conf(struct drm_device *dev, u32 *npipes,
>>
>>
>> struct r600_cs_track {
>> - /* configuration we miror so that we use same code btw kms/ums */
>> + /* configuration we mirror so that we use same code btw kms/ums */
>> u32 group_size;
>> u32 nbanks;
>> u32 npipes;
>> @@ -963,7 +963,7 @@ static int r600_cs_parse_packet0(struct radeon_cs_parser *p,
>> *
>> * This function will test against r600_reg_safe_bm and return 0
>> * if register is safe. If register is not flag as safe this function
>> - * will test it against a list of register needind special handling.
>> + * will test it against a list of register needing special handling.
>> */
>> static int r600_cs_check_reg(struct radeon_cs_parser *p, u32 reg, u32 idx)
>> {
>> --
>
>Those 2 LGTM, but please fix this while you are touching this file:
>
>drivers/gpu/drm/radeon/r600_cs.c:2339: informations ==> information
>
Thanks, I have sent a V2 with the change...
>
>thanks.
>--
>~Randy
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2021-03-24 23:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 13:50 [PATCH] drm/radeon/r600_cs: Couple of typo fixes Bhaskar Chowdhury
2021-03-24 21:48 ` Randy Dunlap
2021-03-24 23:30 ` Bhaskar Chowdhury [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFvLn0E+9AaqLY0e@Slackware \
--to=unixbhaskar@gmail.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox