[PATCH] misc: genwqe: Rudimentary typo fixes

[PATCH] misc: genwqe: Rudimentary typo fixes

[Bhaskar Chowdhury]

s/requsted/requested/  .....two different places.
s/equests/requests/
s/occured/occurred/    ......two different places.
s/conditon/condition/
s/requestors/requesters/


Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
---
 drivers/misc/genwqe/card_ddcb.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/misc/genwqe/card_ddcb.c b/drivers/misc/genwqe/card_ddcb.c
index 0db4000dedf2..98f6cd3fc66a 100644
--- a/drivers/misc/genwqe/card_ddcb.c
+++ b/drivers/misc/genwqe/card_ddcb.c
@@ -316,7 +316,7 @@ static int enqueue_ddcb(struct genwqe_dev *cd, struct ddcb_queue *queue,

 /**
  * copy_ddcb_results() - Copy output state from real DDCB to request
- * @req:        pointer to requsted DDCB parameters
+ * @req:        pointer to requested DDCB parameters
  * @ddcb_no:    pointer to ddcb number being tapped
  *
  * Copy DDCB ASV to request struct. There is no endian
@@ -356,7 +356,7 @@ static void copy_ddcb_results(struct ddcb_requ *req, int ddcb_no)
 }

 /**
- * genwqe_check_ddcb_queue() - Checks DDCB queue for completed work equests.
+ * genwqe_check_ddcb_queue() - Checks DDCB queue for completed work requests.
  * @cd:         pointer to genwqe device descriptor
  * @queue:	queue to be checked
  *
@@ -460,7 +460,7 @@ static int genwqe_check_ddcb_queue(struct genwqe_dev *cd,
 /**
  * __genwqe_wait_ddcb(): Waits until DDCB is completed
  * @cd:         pointer to genwqe device descriptor
- * @req:        pointer to requsted DDCB parameters
+ * @req:        pointer to requested DDCB parameters
  *
  * The Service Layer will update the RETC in DDCB when processing is
  * pending or done.
@@ -498,7 +498,7 @@ int __genwqe_wait_ddcb(struct genwqe_dev *cd, struct ddcb_requ *req)

 	/*
 	 * We need to distinguish 3 cases here:
-	 *   1. rc == 0              timeout occured
+	 *   1. rc == 0              timeout occurred
 	 *   2. rc == -ERESTARTSYS   signal received
 	 *   3. rc > 0               remaining jiffies condition is true
 	 */
@@ -543,7 +543,7 @@ int __genwqe_wait_ddcb(struct genwqe_dev *cd, struct ddcb_requ *req)
 		return -EINVAL;
 	}

-	/* Severe error occured. Driver is forced to stop operation */
+	/* Severe error occurred. Driver is forced to stop operation */
 	if (cd->card_state != GENWQE_CARD_USED) {
 		dev_err(&pci_dev->dev,
 			"[%s] err: DDCB#%d forced to stop (rc=%d)\n",
@@ -1002,7 +1002,7 @@ static int genwqe_next_ddcb_ready(struct genwqe_dev *cd)
  * @cd:         pointer to genwqe device descriptor
  *
  * Keep track on the number of DDCBs which ware currently in the
- * queue. This is needed for statistics as well as conditon if we want
+ * queue. This is needed for statistics as well as condition if we want
  * to wait or better do polling in case of no interrupts available.
  */
 int genwqe_ddcbs_in_flight(struct genwqe_dev *cd)
@@ -1182,7 +1182,7 @@ static irqreturn_t genwqe_vf_isr(int irq, void *dev_id)
  *
  * The idea is to check if there are DDCBs in processing. If there are
  * some finished DDCBs, we process them and wakeup the
- * requestors. Otherwise we give other processes time using
+ * requesters. Otherwise we give other processes time using
  * cond_resched().
  */
 static int genwqe_card_thread(void *data)
--
2.30.1

Re: [PATCH] misc: genwqe: Rudimentary typo fixes

[Randy Dunlap]

On 3/23/21 11:28 PM, Bhaskar Chowdhury wrote:
> 
> s/requsted/requested/  .....two different places.
> s/equests/requests/
> s/occured/occurred/    ......two different places.
> s/conditon/condition/
> s/requestors/requesters/
> 
> 
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> ---
>  drivers/misc/genwqe/card_ddcb.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/misc/genwqe/card_ddcb.c b/drivers/misc/genwqe/card_ddcb.c
> index 0db4000dedf2..98f6cd3fc66a 100644
> --- a/drivers/misc/genwqe/card_ddcb.c
> +++ b/drivers/misc/genwqe/card_ddcb.c


> @@ -1182,7 +1182,7 @@ static irqreturn_t genwqe_vf_isr(int irq, void *dev_id)
>   *
>   * The idea is to check if there are DDCBs in processing. If there are
>   * some finished DDCBs, we process them and wakeup the
> - * requestors. Otherwise we give other processes time using
> + * requesters. Otherwise we give other processes time using

"requestor" seems to be a word AFAICT.

>   * cond_resched().
>   */
>  static int genwqe_card_thread(void *data)
> --

and codespell says (for linux-next):

drivers/misc/genwqe/card_ddcb.c:985: emtpy  ==> empty


The other changes LGTM.

-- 
~Randy

Re: [PATCH] misc: genwqe: Rudimentary typo fixes

[Bhaskar Chowdhury]

[-- Attachment #1: Type: text/plain, Size: 1435 bytes --]

On 14:47 Wed 24 Mar 2021, Randy Dunlap wrote:
>On 3/23/21 11:28 PM, Bhaskar Chowdhury wrote:
>>
>> s/requsted/requested/  .....two different places.
>> s/equests/requests/
>> s/occured/occurred/    ......two different places.
>> s/conditon/condition/
>> s/requestors/requesters/
>>
>>
>> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
>> ---
>>  drivers/misc/genwqe/card_ddcb.c | 14 +++++++-------
>>  1 file changed, 7 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/misc/genwqe/card_ddcb.c b/drivers/misc/genwqe/card_ddcb.c
>> index 0db4000dedf2..98f6cd3fc66a 100644
>> --- a/drivers/misc/genwqe/card_ddcb.c
>> +++ b/drivers/misc/genwqe/card_ddcb.c
>
>
>> @@ -1182,7 +1182,7 @@ static irqreturn_t genwqe_vf_isr(int irq, void *dev_id)
>>   *
>>   * The idea is to check if there are DDCBs in processing. If there are
>>   * some finished DDCBs, we process them and wakeup the
>> - * requestors. Otherwise we give other processes time using
>> + * requesters. Otherwise we give other processes time using
>
>"requestor" seems to be a word AFAICT.
It was certainly not showing to me , that was why the change.Let me go back
and check, if I missed it.
>
>>   * cond_resched().
>>   */
>>  static int genwqe_card_thread(void *data)
>> --
>
>and codespell says (for linux-next):
>
>drivers/misc/genwqe/card_ddcb.c:985: emtpy  ==> empty
>

Thanks, good catch...will do a V2 ...
>
>The other changes LGTM.
>
>--
>~Randy
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]