From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Wan Jiabing <wanjiabing@vivo.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
linux-kernel@vger.kernel.org, kael_w@yeah.net
Subject: Re: [PATCH] tools: perf: Remove duplicate includes
Date: Thu, 25 Mar 2021 09:58:52 -0300 [thread overview]
Message-ID: <YFyJDCk/S+el4SDi@kernel.org> (raw)
In-Reply-To: <20210323050139.287461-1-wanjiabing@vivo.com>
Em Tue, Mar 23, 2021 at 01:01:39PM +0800, Wan Jiabing escreveu:
> sys/stat.h has been included at line 23, so remove the
> duplicate one at line 27.
> linux/string.h has been included at line 7, so remove the
> duplicate one at line 9.
> time.h has been included at line 14, so remove the
> duplicate one at line 28.
Thanks, applied.
- Arnaldo
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> tools/perf/builtin-daemon.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/tools/perf/builtin-daemon.c b/tools/perf/builtin-daemon.c
> index ace8772a4f03..632ecd010a4f 100644
> --- a/tools/perf/builtin-daemon.c
> +++ b/tools/perf/builtin-daemon.c
> @@ -6,7 +6,6 @@
> #include <linux/zalloc.h>
> #include <linux/string.h>
> #include <linux/limits.h>
> -#include <linux/string.h>
> #include <string.h>
> #include <sys/file.h>
> #include <signal.h>
> @@ -24,8 +23,6 @@
> #include <sys/signalfd.h>
> #include <sys/wait.h>
> #include <poll.h>
> -#include <sys/stat.h>
> -#include <time.h>
> #include "builtin.h"
> #include "perf.h"
> #include "debug.h"
> --
> 2.25.1
>
--
- Arnaldo
prev parent reply other threads:[~2021-03-25 13:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 5:01 [PATCH] tools: perf: Remove duplicate includes Wan Jiabing
2021-03-25 12:58 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFyJDCk/S+el4SDi@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=kael_w@yeah.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=wanjiabing@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox