From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AADA9C433DB for ; Thu, 25 Mar 2021 13:24:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 75B9B61A17 for ; Thu, 25 Mar 2021 13:24:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230191AbhCYNYS (ORCPT ); Thu, 25 Mar 2021 09:24:18 -0400 Received: from mga04.intel.com ([192.55.52.120]:7598 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229731AbhCYNXr (ORCPT ); Thu, 25 Mar 2021 09:23:47 -0400 IronPort-SDR: o0ZTxGrFrj72cbYX36iDdY7EUOiQLoNcVQdU6o2sufIAenHjrtAdCuwak3/01eaoxdOH/F/zrE oxOFzOSUd9Fw== X-IronPort-AV: E=McAfee;i="6000,8403,9933"; a="188628354" X-IronPort-AV: E=Sophos;i="5.81,277,1610438400"; d="scan'208";a="188628354" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2021 06:23:47 -0700 IronPort-SDR: j2N33Qd84WMcvnjdw27sNTAmh6DExk6dS+RDKkgYTwUzZhsG6p6MlvV+YRPOqzWUwOI+0oiAU3 oRmrbEpLLV6w== X-IronPort-AV: E=Sophos;i="5.81,277,1610438400"; d="scan'208";a="375068246" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2021 06:23:44 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lPPxb-00G3Ks-0i; Thu, 25 Mar 2021 15:23:39 +0200 Date: Thu, 25 Mar 2021 15:23:39 +0200 From: Andy Shevchenko To: Wan Jiabing Cc: Thomas Gleixner , Sergey Senozhatsky , Petr Mladek , Peter Zijlstra , linux-kernel@vger.kernel.org, kael_w@yeah.net Subject: Re: [PATCH] include: linux: debug_locks: Remove duplicate declaration Message-ID: References: <20210325022707.840531-1-wanjiabing@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 25, 2021 at 03:22:22PM +0200, Andy Shevchenko wrote: > On Thu, Mar 25, 2021 at 10:26:58AM +0800, Wan Jiabing wrote: > > struct task_struct is declared at 9th line. Remove the duplicate. > > It seems the duplicate is the other one and you removed wrong one. Okay, they are on the same level of ifdeffery, technically there is no difference. Practically the other one closer to its user. -- With Best Regards, Andy Shevchenko