From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7A11C433ED for ; Wed, 7 Apr 2021 09:40:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 73C0E61260 for ; Wed, 7 Apr 2021 09:40:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350203AbhDGJkY (ORCPT ); Wed, 7 Apr 2021 05:40:24 -0400 Received: from mga03.intel.com ([134.134.136.65]:7171 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237543AbhDGJjm (ORCPT ); Wed, 7 Apr 2021 05:39:42 -0400 IronPort-SDR: DyBse/M1Cr5AyIJdDnV7aXag/z2okBT8ztnZEDEu1kQ7SRQ/XS75bnOM0rejQYaPIhWsqfCdHx lef3/6YdtqtQ== X-IronPort-AV: E=McAfee;i="6000,8403,9946"; a="193310969" X-IronPort-AV: E=Sophos;i="5.82,203,1613462400"; d="scan'208";a="193310969" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Apr 2021 02:38:44 -0700 IronPort-SDR: FxODBIASr2lF1YeruIMYHWmTcR7zUvk9LZwfr26DnZs/snKilN3T2P4/DQFrXhXpJ8aY2X9FQ+ TE/gmQqQk2mA== X-IronPort-AV: E=Sophos;i="5.82,203,1613462400"; d="scan'208";a="458288146" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Apr 2021 02:38:41 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lU4dv-001yYn-6J; Wed, 07 Apr 2021 12:38:35 +0300 Date: Wed, 7 Apr 2021 12:38:35 +0300 From: Andy Shevchenko To: Guenter Roeck Cc: Greg Kroah-Hartman , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Matthias Schiffer Subject: Re: [PATCH v1 1/1] driver core: platform: Make platform_get_irq_optional() optional Message-ID: References: <20210331144526.19439-1-andriy.shevchenko@linux.intel.com> <20210406192514.GA34677@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210406192514.GA34677@roeck-us.net> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 06, 2021 at 12:25:14PM -0700, Guenter Roeck wrote: > On Wed, Mar 31, 2021 at 05:45:26PM +0300, Andy Shevchenko wrote: > > Currently the platform_get_irq_optional() returns an error code even > > if IRQ resource sumply has not been found. It prevents caller to be > > error code agnostic in their error handling. > > > > Now: > > ret = platform_get_irq_optional(...); > > if (ret != -ENXIO) > > return ret; // respect deferred probe > > if (ret > 0) > > ...we get an IRQ... > > > > After proposed change: > > ret = platform_get_irq_optional(...); > > if (ret < 0) > > return ret; > > if (ret > 0) > > ...we get an IRQ... > > > > Reported-by: Matthias Schiffer > > Signed-off-by: Andy Shevchenko > > This patch causes all my "sh" emulations to stall during boot with the > following repeated error message. > > sh-sci sh-sci.1: Can't allocate rx full IRQ > > Reverting this patch fixes the problem (and the message is gone). > Bisect log is attached. I believe it reveals some "interesting" error handling there. I'm going to propose a solution soon. Thanks for the report! -- With Best Regards, Andy Shevchenko