From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF90CC433ED for ; Thu, 8 Apr 2021 07:18:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 87F1961157 for ; Thu, 8 Apr 2021 07:18:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230142AbhDHHTD (ORCPT ); Thu, 8 Apr 2021 03:19:03 -0400 Received: from 8bytes.org ([81.169.241.247]:33988 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229517AbhDHHTB (ORCPT ); Thu, 8 Apr 2021 03:19:01 -0400 Received: by theia.8bytes.org (Postfix, from userid 1000) id EA26C426; Thu, 8 Apr 2021 09:18:49 +0200 (CEST) Date: Thu, 8 Apr 2021 09:18:48 +0200 From: Joerg Roedel To: Nadav Amit Cc: Will Deacon , Jiajun Cao , "iommu@lists.linux-foundation.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] iommu/amd: page-specific invalidations for more than one page Message-ID: References: <20210323210619.513069-1-namit@vmware.com> <71C74038-943D-4041-B6FF-09A8C40CA204@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <71C74038-943D-4041-B6FF-09A8C40CA204@vmware.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Nadav, On Wed, Apr 07, 2021 at 05:57:31PM +0000, Nadav Amit wrote: > I tested it on real bare-metal hardware. I ran some basic I/O workloads > with the IOMMU enabled, checkers enabled/disabled, and so on. > > However, I only tested the IOMMU-flushes and I did not test that the > device-IOTLB flush work, since I did not have the hardware for that. > > If you can refer me to the old patches, I will have a look and see > whether I can see a difference in the logic or test them. If you want > me to run different tests - let me know. If you want me to remove > the device-IOTLB invalidations logic - that is also fine with me. Here is the patch-set, it is from 2010 and against a very old version of the AMD IOMMU driver: https://lore.kernel.org/lkml/1265898797-32183-1-git-send-email-joerg.roedel@amd.com/ Regards, Joerg