From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CFA8C433ED for ; Thu, 8 Apr 2021 10:48:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 55A186113D for ; Thu, 8 Apr 2021 10:48:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230476AbhDHKse (ORCPT ); Thu, 8 Apr 2021 06:48:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:50892 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229721AbhDHKsW (ORCPT ); Thu, 8 Apr 2021 06:48:22 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 99AC861130; Thu, 8 Apr 2021 10:48:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1617878891; bh=PLEqyjaoSZqxWZzmTtM4yUUjZCs5Y+H9HNoAmhQTFiI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EJdKpA+QCLdUbMnCb83YjVkbIuXr8kScNBngpcWH3Nj79mI3J23MuUIFludXnOpU7 MmCTuWKP1PBLgGmP+afC60zBBlo1CtyRHAmSIY6rygbOja7GvsMs9QqI7u91MOjrGv U0T0ZmlUF9QQrtYqkpIXjHw5S1ijlWA2fdiv0k5E= Date: Thu, 8 Apr 2021 12:48:08 +0200 From: Greg KH To: Jiapeng Chong Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: ks7010: remove useless variable Message-ID: References: <1617875479-58849-1-git-send-email-jiapeng.chong@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1617875479-58849-1-git-send-email-jiapeng.chong@linux.alibaba.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 08, 2021 at 05:51:19PM +0800, Jiapeng Chong wrote: > Fix the following gcc warning: > > drivers/staging/ks7010/ks_hostif.c:929:19: warning: variable ‘noise’ set > but not used [-Wunused-but-set-variable]. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > --- > drivers/staging/ks7010/ks_hostif.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c > index 8bc3b7d..499161d 100644 > --- a/drivers/staging/ks7010/ks_hostif.c > +++ b/drivers/staging/ks7010/ks_hostif.c > @@ -926,14 +926,13 @@ void hostif_bss_scan_confirm(struct ks_wlan_private *priv) > void hostif_phy_information_confirm(struct ks_wlan_private *priv) > { > struct iw_statistics *wstats = &priv->wstats; > - u8 rssi, signal, noise; > + u8 rssi, signal; > u8 link_speed; > u32 transmitted_frame_count, received_fragment_count; > u32 failed_count, fcs_error_count; > > rssi = get_byte(priv); > signal = get_byte(priv); > - noise = get_byte(priv); Are you sure you did not just break the functionality of the device here? thanks, greg k-h