Re: [PATCH v1 1/5] bitmap: Make bitmap_remap() and bitmap_bitremap() available to users

Yury Norov
2021-04-08T16:53:01Z

On Thu, Apr 08, 2021 at 05:55:57PM +0300, Andy Shevchenko wrote:
> Currently the bitmap_remap() and bitmap_bitremap() are available
> only for CONFIG_NUMA=y case, while some users may benefit out of it
> and being independent to NUMA code. Make them available to users
> by moving out of ifdeffery and exporting for modules.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> lib/bitmap.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/lib/bitmap.c b/lib/bitmap.c
> index 74ceb02f45e3..7b6b2a67a6a6 100644
> --- a/lib/bitmap.c
> +++ b/lib/bitmap.c
> @@ -784,8 +784,6 @@ int bitmap_parse(const char *start, unsigned int buflen,
> }
> EXPORT_SYMBOL(bitmap_parse);
>
> -
> -#ifdef CONFIG_NUMA
> /**
> * bitmap_pos_to_ord - find ordinal of set bit at given position in bitmap
> * @buf: pointer to a bitmap
> @@ -894,6 +892,7 @@ void bitmap_remap(unsigned long *dst, const unsigned long *src,
> set_bit(bitmap_ord_to_pos(new, n % w, nbits), dst);
> }
> }
> +EXPORT_SYMBOL(bitmap_remap);
>
> /**
> * bitmap_bitremap - Apply map defined by a pair of bitmaps to a single bit
> @@ -931,7 +930,9 @@ int bitmap_bitremap(int oldbit, const unsigned long *old,
> else
> return bitmap_ord_to_pos(new, n % w, bits);
> }
> +EXPORT_SYMBOL(bitmap_bitremap);
>
> +#ifdef CONFIG_NUMA
> /**
> * bitmap_onto - translate one bitmap relative to another
> * @dst: resulting translated bitmap
> --
> 2.30.2

Acked-by: Yury Norov <yury.norov@gmail.com>