Re: [PATCH 13/13] tty: clean include/linux/tty.h up

Greg Kroah-Hartman
2021-04-08T17:51:11Z

On Thu, Apr 08, 2021 at 02:51:34PM +0200, Greg Kroah-Hartman wrote:
> There are a lot of tty-core-only functions that are listed in
> include/linux/tty.h. Move them to drivers/tty/tty.h so that no one else
> can accidentally call them or think that they are public functions.
>
> Cc: Jiri Slaby <jirislaby@kernel.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> drivers/tty/n_gsm.c | 1 +
> drivers/tty/n_hdlc.c | 1 +
> drivers/tty/tty.h | 37 +++++++++++++++++++++++++++++++++++++
> include/linux/tty.h | 34 ----------------------------------
> 4 files changed, 39 insertions(+), 34 deletions(-)

This needs a "tty.h" inclusion into drivers/tty/tty_baudrate.c,
otherwise it's a build warning, I missed that, sorry. Will add that to
the next revision if it's needed, or just fix it up when committing it.

thanks,

greg k-h