From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5E06C433B4 for ; Thu, 8 Apr 2021 18:10:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 90A95610FC for ; Thu, 8 Apr 2021 18:10:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232604AbhDHSKh (ORCPT ); Thu, 8 Apr 2021 14:10:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:36690 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231716AbhDHSKf (ORCPT ); Thu, 8 Apr 2021 14:10:35 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 637BA610CA; Thu, 8 Apr 2021 18:10:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1617905424; bh=b6UhGDmqyefe9/qRro35BT4OuGSkRxu8JrK/cweYHaU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vRbXIvaTTZpAhWapgDxanygLRb1k8inDDUlUr8Zx8mZm/oe+AuTPhbbIM9XR03qKN Hwfww9S3q127AT1zTg8PvyqEwhPCuPJBIY4Zj2bHkOVwlFX/Nn7uj5KKZnc0FktKnP uDqqPeNpqKJaXRwElGGzhjNmn4Txdqp4tcugEEfI= Date: Thu, 8 Apr 2021 20:10:21 +0200 From: Greg KH To: Min Li Cc: "derek.kiernan@xilinx.com" , "dragan.cvetic@xilinx.com" , "arnd@arndb.de" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH net-next v3 2/2] misc: Add Renesas Synchronization Management Unit (SMU) support Message-ID: References: <1617846650-10058-1-git-send-email-min.li.xe@renesas.com> <1617846650-10058-2-git-send-email-min.li.xe@renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 08, 2021 at 06:01:42PM +0000, Min Li wrote: > > > > That does not make sense, this is only one kernel module, with one .h file in > > this patch, I do not see those other files you are talking about... > > > > And if you have named registers that are identical, and yet you only work on > > one device, that feels like a design flaw somewhere :) > > > > Hi Greg, the register files are in the 1/2 patch for the mfd part of the change. > The reason they have same named register is because they are all synchronization > devices and they share some similar features But what does that have to do with the misc device? totally confused, greg k-h