From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Gustavo Pimentel <Gustavo.Pimentel@synopsys.com>
Cc: linux-doc@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Derek Kiernan" <derek.kiernan@xilinx.com>,
"Dragan Cvetic" <dragan.cvetic@xilinx.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Jonathan Corbet" <corbet@lwn.net>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Krzysztof Wilczyński" <kw@linux.com>
Subject: Re: [PATCH v9 4/4] docs: ABI: Add sysfs documentation interface of dw-xdata-pcie driver
Date: Mon, 29 Mar 2021 12:08:11 +0200 [thread overview]
Message-ID: <YGGnC8LouF+paZ6G@kroah.com> (raw)
In-Reply-To: <5840637a206dd1287caf142a0dbedf0dac9ccd48.1617011831.git.gustavo.pimentel@synopsys.com>
On Mon, Mar 29, 2021 at 11:59:40AM +0200, Gustavo Pimentel wrote:
> This patch describes the sysfs interface implemented on the dw-xdata-pcie
> driver.
>
> Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
> ---
> Documentation/ABI/testing/sysfs-driver-xdata | 46 ++++++++++++++++++++++++++++
> 1 file changed, 46 insertions(+)
> create mode 100644 Documentation/ABI/testing/sysfs-driver-xdata
>
> diff --git a/Documentation/ABI/testing/sysfs-driver-xdata b/Documentation/ABI/testing/sysfs-driver-xdata
> new file mode 100644
> index 00000000..66af19a
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-driver-xdata
> @@ -0,0 +1,46 @@
> +What: /sys/class/misc/drivers/dw-xdata-pcie.<device>/write
> +Date: April 2021
> +KernelVersion: 5.13
> +Contact: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
> +Description: Allows the user to enable the PCIe traffic generator which
> + will create write TLPs frames - from the Root Complex to the
> + Endpoint direction.
> + Usage e.g.
> + echo 1 > /sys/class/misc/dw-xdata-pcie.<device>/write
Again, this does not match the code. Either fix the code (which I
recommend), or change this and the other sysfs descriptions of writing
values here.
thanks,
greg k-h
next prev parent reply other threads:[~2021-03-29 10:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-29 9:59 [PATCH v9 0/4] misc: Add Add Synopsys DesignWare xData IP driver Gustavo Pimentel
2021-03-29 9:59 ` [PATCH v9 1/4] misc: " Gustavo Pimentel
2021-03-29 9:59 ` [PATCH v9 2/4] Documentation: misc-devices: Add Documentation for dw-xdata-pcie driver Gustavo Pimentel
2021-03-29 9:59 ` [PATCH v9 3/4] MAINTAINERS: Add Synopsys xData IP driver maintainer Gustavo Pimentel
2021-03-29 9:59 ` [PATCH v9 4/4] docs: ABI: Add sysfs documentation interface of dw-xdata-pcie driver Gustavo Pimentel
2021-03-29 10:08 ` Greg Kroah-Hartman [this message]
2021-03-29 10:25 ` Gustavo Pimentel
2021-03-29 10:40 ` Greg Kroah-Hartman
2021-03-29 10:53 ` Gustavo Pimentel
2021-03-29 11:03 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGGnC8LouF+paZ6G@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Gustavo.Pimentel@synopsys.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=corbet@lwn.net \
--cc=derek.kiernan@xilinx.com \
--cc=dragan.cvetic@xilinx.com \
--cc=kw@linux.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox