From: Petr Mladek <pmladek@suse.com>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
Alexei Starovoitov <ast@kernel.org>, Jessica Yu <jeyu@kernel.org>,
Evan Green <evgreen@chromium.org>,
Hsin-Yi Wang <hsinyi@chromium.org>,
Steven Rostedt <rostedt@goodmis.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-doc@vger.kernel.org, Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH v2 04/12] module: Add printk format to add module build ID to stacktraces
Date: Tue, 30 Mar 2021 12:51:26 +0200 [thread overview]
Message-ID: <YGMCrlUAlcxdlt06@alley> (raw)
In-Reply-To: <161662492346.3012082.17886011577458863951@swboyd.mtv.corp.google.com>
On Wed 2021-03-24 15:28:43, Stephen Boyd wrote:
> Quoting Rasmus Villemoes (2021-03-24 15:21:34)
> > On 24/03/2021 20.11, Stephen Boyd wrote:
> > > Quoting Rasmus Villemoes (2021-03-24 02:57:13)
> >
> > >>
> > >> Is there any reason you didn't just make b an optional flag that could
> > >> be specified with or without R? I suppose the parsing is more difficult
> > >> with several orthogonal flags (see escaped_string()), but it's a little
> > >> easier to understand. Dunno, it's not like we're gonna think of 10 other
> > >> things that could be printed for a symbol, so perhaps it's fine.
> > >>
> > >
> > > I think I follow. So %pSb or %pSRb? If it's easier to understand then
> > > sure. I was trying to avoid checking another character beyond fmt[1] but
> > > it should be fine if fmt[1] is already 'R'.
>
> I'm inclined to use %pSb and %pSRb. The code looks to simpler and I
> suppose we can worry about different ordering/combination problems if it
> comes to it.
>
> ---8<---
> diff --git a/lib/vsprintf.c b/lib/vsprintf.c
> index 41ddc353ebb8..0e94cba5ba20 100644
> --- a/lib/vsprintf.c
> +++ b/lib/vsprintf.c
> @@ -968,6 +968,8 @@ char *symbol_string(char *buf, char *end, void *ptr,
> #ifdef CONFIG_KALLSYMS
> if (*fmt == 'B')
> sprint_backtrace(sym, value);
> + else if (*fmt == 'S' && (fmt[1] == 'b' || (fmt[1] == 'R' && fmt[2] == 'b')))
> + sprint_symbol_stacktrace(sym, value);
> else if (*fmt != 's')
> sprint_symbol(sym, value);
> else
I prefer the extra "b" flag as well. It helps me to understand and
memorize[*] the meaning.
[*] at least short-time memorize ;-)
Best Regards,
Petr
next prev parent reply other threads:[~2021-03-30 10:52 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 2:04 [PATCH v2 00/12] Add build ID to stacktraces Stephen Boyd
2021-03-24 2:04 ` [PATCH v2 01/12] buildid: Add API to parse build ID out of buffer Stephen Boyd
2021-03-24 2:04 ` [PATCH v2 02/12] buildid: Add method to get running kernel's build ID Stephen Boyd
2021-03-24 9:24 ` Rasmus Villemoes
2021-03-24 19:06 ` Stephen Boyd
2021-03-24 2:04 ` [PATCH v2 03/12] dump_stack: Add vmlinux build ID to stack traces Stephen Boyd
2021-03-24 11:22 ` Andy Shevchenko
2021-03-24 19:01 ` Stephen Boyd
2021-03-24 2:04 ` [PATCH v2 04/12] module: Add printk format to add module build ID to stacktraces Stephen Boyd
2021-03-24 9:57 ` Rasmus Villemoes
2021-03-24 19:11 ` Stephen Boyd
2021-03-24 22:21 ` Rasmus Villemoes
2021-03-24 22:28 ` Stephen Boyd
2021-03-30 10:51 ` Petr Mladek [this message]
2021-03-30 10:29 ` Petr Mladek
2021-03-30 19:12 ` Stephen Boyd
2021-03-24 2:04 ` [PATCH v2 05/12] arm64: stacktrace: Use %pSb for backtrace printing Stephen Boyd
2021-03-24 2:04 ` [PATCH v2 06/12] x86/dumpstack: " Stephen Boyd
2021-03-24 2:04 ` [PATCH v2 07/12] scripts/decode_stacktrace.sh: Support debuginfod Stephen Boyd
2021-03-24 11:27 ` Andy Shevchenko
2021-03-24 22:22 ` Stephen Boyd
2021-03-24 2:04 ` [PATCH v2 08/12] scripts/decode_stacktrace.sh: Silence stderr messages from addr2line/nm Stephen Boyd
2021-03-24 2:04 ` [PATCH v2 09/12] scripts/decode_stacktrace.sh: Indicate 'auto' can be used for base path Stephen Boyd
2021-03-24 2:04 ` [PATCH v2 10/12] buildid: Mark some arguments const Stephen Boyd
2021-03-24 2:04 ` [PATCH v2 11/12] buildid: Fix kernel-doc notation Stephen Boyd
2021-03-24 2:04 ` [PATCH v2 12/12] kdump: Use vmlinux_build_id() to simplify Stephen Boyd
2021-03-24 8:55 ` [PATCH v2 00/12] Add build ID to stacktraces Christoph Hellwig
2021-03-25 11:06 ` peter enderborg
2021-03-25 23:21 ` Stephen Boyd
2021-03-30 10:59 ` Petr Mladek
[not found] ` <32011616573677@mail.yandex-team.ru>
2021-03-24 19:04 ` Stephen Boyd
2021-03-25 11:14 ` peter enderborg
2021-03-25 23:18 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGMCrlUAlcxdlt06@alley \
--to=pmladek@suse.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ast@kernel.org \
--cc=evgreen@chromium.org \
--cc=hsinyi@chromium.org \
--cc=jeyu@kernel.org \
--cc=jolsa@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=swboyd@chromium.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox