From: Sasha Levin <sashal@kernel.org>
To: Pavel Tatashin <pasha.tatashin@soleen.com>
Cc: tyhicks@linux.microsoft.com, jmorris@namei.org, will@kernel.org,
anshuman.khandual@arm.com, ardb@kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
gregkh@linuxfoundation.org
Subject: Re: [PATCH] [Backport for stable 5.11] arm64: mm: correct the inside linear map boundaries during hotplug check
Date: Tue, 30 Mar 2021 13:08:26 -0400 [thread overview]
Message-ID: <YGNbCjq92b73OBUR@sashalap> (raw)
In-Reply-To: <20210329142847.402167-1-pasha.tatashin@soleen.com>
On Mon, Mar 29, 2021 at 10:28:47AM -0400, Pavel Tatashin wrote:
>commit ee7febce051945be28ad86d16a15886f878204de upstream.
>
>Memory hotplug may fail on systems with CONFIG_RANDOMIZE_BASE because the
>linear map range is not checked correctly.
>
>The start physical address that linear map covers can be actually at the
>end of the range because of randomization. Check that and if so reduce it
>to 0.
>
>This can be verified on QEMU with setting kaslr-seed to ~0ul:
>
>memstart_offset_seed = 0xffff
>START: __pa(_PAGE_OFFSET(vabits_actual)) = ffff9000c0000000
>END: __pa(PAGE_END - 1) = 1000bfffffff
>
>Fixes: 58284a901b42 ("arm64/mm: Validate hotplug range before creating linear mapping")
>Signed-off-by: Pavel Tatashin <pasha.tatashin@soleen.com>
>Tested-by: Tyler Hicks <tyhicks@linux.microsoft.com>
>Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
Queued up, thanks!
--
Thanks,
Sasha
prev parent reply other threads:[~2021-03-30 17:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-29 14:28 [PATCH] [Backport for stable 5.11] arm64: mm: correct the inside linear map boundaries during hotplug check Pavel Tatashin
2021-03-30 17:08 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGNbCjq92b73OBUR@sashalap \
--to=sashal@kernel.org \
--cc=anshuman.khandual@arm.com \
--cc=ardb@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pasha.tatashin@soleen.com \
--cc=stable@vger.kernel.org \
--cc=tyhicks@linux.microsoft.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox