From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA714C433ED for ; Wed, 31 Mar 2021 20:08:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 738FD6100B for ; Wed, 31 Mar 2021 20:08:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236432AbhCaUHo (ORCPT ); Wed, 31 Mar 2021 16:07:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236323AbhCaUHX (ORCPT ); Wed, 31 Mar 2021 16:07:23 -0400 Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3EA10C06174A for ; Wed, 31 Mar 2021 13:07:23 -0700 (PDT) Received: by mail-pg1-x535.google.com with SMTP id q10so101288pgj.2 for ; Wed, 31 Mar 2021 13:07:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=j8v7zlQCarZgdFLgATsFe+vW/NFhoDJt/9MWBvCMW3o=; b=PHWdya59ypGDcuhE+/Lj0qikX5VKKJXVdJWzs0hZfbTtT1pTrku9dxeF2BRmS1lpxh YfrvMh564HSSwf9crONrxjhy6Kvwgho+tI9MxKnecxhLK6q7jWUX5JfW1/uFuYuAUXn9 FB7rFnOcSaxSCaHGTwmJj5M5KHbjStoBJjZ7T5lemUwbT9co1C3P2SGvnxkM5xlmc8kZ gYMSH/b7yz7JIPwQxloWvXZhufWderMls7/bo/K2TvhsD4rDuM32hgRZxmGsCzCwe4UH 8KETRP77LjLRCoEX0fuOSTEXA9Z3C9YUd3Z87sCWhxtpwzTmj37e/L2uP8XfHkW+s6El 7nBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=j8v7zlQCarZgdFLgATsFe+vW/NFhoDJt/9MWBvCMW3o=; b=a8ZKkc16R2SI8044uqcKWzFzsOr3sDPJi/WqXpza6bztMjF1uYXXH4Dt65tVVcO/yx dNzCBltUr6J8reH0RhEMZ40envlpTFbJ3z+rmepb8Rslv4i83GkhF6VXhKCVhB8qMbGE 4SXAn+eCalfFqLWmq9COpwsvGFOHIhkASoqF4FpOV9kOzPOs5e61B+cSaW0K5AP/EMz+ DBmcATb0geqEQPOay75CgBNYaQZ7A/JyfY/7JKCW2577eHJ1guv7yHZj2N7qOxnDcgDc yW/BUJ1AfuEaYO/tySjKwv749H4tUXDDTpf8XfCOPNkOwz0meWoj6AkdLzQdZCjBi8bL 6m+w== X-Gm-Message-State: AOAM532ihQmdd8szgVrsmzLk+/g5LDldg9XgOiSdyKHm5oNgGI0+EHd/ wlv8KeHizGbDsZ8ZEGm82Wx0ZQ== X-Google-Smtp-Source: ABdhPJxMs6vJpij60DibOiWc5Zg+qRDcCo87p5sWjlsdO7CJNWPOggYWCf1uv/7lZH7V2p6KWWaS0w== X-Received: by 2002:a63:4763:: with SMTP id w35mr4698071pgk.226.1617221242566; Wed, 31 Mar 2021 13:07:22 -0700 (PDT) Received: from google.com (240.111.247.35.bc.googleusercontent.com. [35.247.111.240]) by smtp.gmail.com with ESMTPSA id fa21sm3093569pjb.41.2021.03.31.13.07.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Mar 2021 13:07:21 -0700 (PDT) Date: Wed, 31 Mar 2021 20:07:18 +0000 From: Sean Christopherson To: Kees Cook Cc: Sami Tolvanen , Fangrui Song , Masahiro Yamada , Michal Marek , Nathan Chancellor , Nick Desaulniers , linux-kbuild , LKML , clang-built-linux Subject: Re: [PATCH] kbuild: Merge module sections if and only if CONFIG_LTO_CLANG is enabled Message-ID: References: <20210322234438.502582-1-seanjc@google.com> <202103311228.D42822B@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202103311228.D42822B@keescook> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 31, 2021, Kees Cook wrote: > On Wed, Mar 24, 2021 at 10:45:36PM +0000, Sean Christopherson wrote: > > On Tue, Mar 23, 2021, Sami Tolvanen wrote: > > > On Tue, Mar 23, 2021 at 9:36 AM Sean Christopherson wrote: > > > > > > > > On Tue, Mar 23, 2021, Sami Tolvanen wrote: > > > > > On Mon, Mar 22, 2021 at 4:44 PM Sean Christopherson wrote: > > > > > > > > > > > > Merge module sections only when using Clang LTO. With gcc-10, merging > > > > > > sections does not appear to update the symbol tables for the module, > > > > > > e.g. 'readelf -s' shows the value that a symbol would have had, if > > > > > > sections were not merged. > > > > > > > > > > I'm fine with limiting this to LTO only, but it would be helpful to > > > > > understand which sections are actually getting merged here. > > > > > > > > It doesn't appear to matter which sections get merged, the tables only show the > > > > correct data if there is no merging whatsoever, e.g. allowing merging for any > > > > one of the four types (.bss, .data, .rodata and .text) results in breakage. > > > > AFAICT, merging any sections causes the layout to change and throw off the > > > > symbol tables. > > > > > > Thanks for the clarification. I can reproduce this issue with gcc + > > > bfd if any of the sections are merged, but gcc + lld produces valid > > > symbol tables. > > > > FWIW, clang + bfd also produces mangled tables, so it does appear to be bfd > > specific. > > Are you able to open a bug against bfd for this? Yes? I'll ping you when I run into trouble ;-)