From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0194BC43600 for ; Thu, 1 Apr 2021 06:01:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BCB6261029 for ; Thu, 1 Apr 2021 06:01:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233266AbhDAF7i (ORCPT ); Thu, 1 Apr 2021 01:59:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:37652 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233255AbhDAF7P (ORCPT ); Thu, 1 Apr 2021 01:59:15 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E032361029; Thu, 1 Apr 2021 05:59:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1617256755; bh=XD5dFTafi/zh+nbVhSvc/b+NA8PLtkafirLsfoVxupQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dXyjK55TzCMFvWujSIhwio+Y7BjQ0ZGXfPzsFH6khYyTLw9mRYNjdwX+mN4eZMIQ7 pHq7SPRtDRTAvj34fH2JI3Hk3L/czS6TteSXmP8cEkRl16rF0ZVi7SStZB7doGonSP DeIgl6v/pLN0ubNiOO9bcjIrQlVb+Tcy+Zf+YGvk= Date: Thu, 1 Apr 2021 07:59:10 +0200 From: Greg KH To: Yang Yingliang Cc: linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, johan@kernel.org, elder@kernel.org Subject: Re: [PATCH -next v2] staging: greybus: camera: Switch to memdup_user_nul() Message-ID: References: <20210401031752.2861248-1-yangyingliang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210401031752.2861248-1-yangyingliang@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 01, 2021 at 11:17:52AM +0800, Yang Yingliang wrote: > Use memdup_user_nul() helper instead of open-coding to > simplify the code. > > Reported-by: Hulk Robot > Signed-off-by: Yang Yingliang > --- > drivers/staging/greybus/camera.c | 13 +++---------- > 1 file changed, 3 insertions(+), 10 deletions(-) What changed from v1? Always put that below the --- line like the documentation asks you to. Please fix up and send a v3. thanks, greg k-h