The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: George Zhang <georgezhang@vmware.com>,
	Arnd Bergmann <arnd@arndb.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] misc: vmw_vmci: initialize payload passed to vmci_send_datagram()
Date: Thu, 1 Apr 2021 09:10:48 +0200	[thread overview]
Message-ID: <YGVx+A7VyV7LVLPW@kroah.com> (raw)
In-Reply-To: <29011e79-edb4-35ce-10ab-6d0fd5fd2ec5@i-love.sakura.ne.jp>

On Thu, Apr 01, 2021 at 03:53:02PM +0900, Tetsuo Handa wrote:
> On 2021/04/01 15:18, Greg Kroah-Hartman wrote:
> > On Thu, Apr 01, 2021 at 02:57:47PM +0900, Tetsuo Handa wrote:
> >> KMSAN complains that the vmci_use_ppn64() == false path in
> >> vmci_dbell_register_notification_bitmap() left upper 32bits of
> >> bitmap_set_msg.bitmap_ppn64 member uninitialized.
> >>
> >> KMSAN also complains that vmci_check_host_caps() left the payload part
> >> of check_msg uninitialized.
> >>
> > 
> > What commit does this "fix"?  Can you resend with a proper "Fixes:" tag
> > so we know where it needs to be backported to?
> 
> It seems that this problem exists since the introduction.
> 
>   commit 83e2ec765be03e8a8a07619e65df70b48a1db023
>   Author: George Zhang <georgezhang@vmware.com>
>   Date:   Tue Jan 8 15:53:51 2013 -0800
>   
>       VMCI: doorbell implementation.
>   
>   commit 1f166439917b69d3046e2e49fe923579d9181212
>   Author: George Zhang <georgezhang@vmware.com>
>   Date:   Tue Jan 8 15:55:32 2013 -0800
>   
>       VMCI: guest side driver implementation.
> 
> But this patch should be safe to backport to as old as possible, for
> this patch is merely explicitly initializing variables.

Great, can you please resend with the Fixes: tag and a cc: stable in the
signed-off-by area as well when you resend these as a 2 patch series?

thanks,

greg k-h

  reply	other threads:[~2021-04-01  7:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-01  5:57 [PATCH] misc: vmw_vmci: initialize payload passed to vmci_send_datagram() Tetsuo Handa
2021-04-01  6:18 ` Greg Kroah-Hartman
2021-04-01  6:53   ` Tetsuo Handa
2021-04-01  7:10     ` Greg Kroah-Hartman [this message]
2021-04-01  6:18 ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YGVx+A7VyV7LVLPW@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=georgezhang@vmware.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox