From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFBCBC433B4 for ; Fri, 2 Apr 2021 09:00:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8435161003 for ; Fri, 2 Apr 2021 09:00:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234434AbhDBJAf (ORCPT ); Fri, 2 Apr 2021 05:00:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229605AbhDBJA2 (ORCPT ); Fri, 2 Apr 2021 05:00:28 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 936CFC0613E6 for ; Fri, 2 Apr 2021 02:00:27 -0700 (PDT) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E69632C1; Fri, 2 Apr 2021 11:00:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1617354024; bh=elTh91fHBqoRE3n15Vt6YQfqLzAPhdsnX4FGuvqKbJM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oWFPNwZpRW0+ESGW3PxJDKemt4sdh4C2jxyzELlrhmAyenar17Mj6v3OiAJ7L8+MS Cn415IdbXHMs57Nwqp7UyBPce4jNY+QIqHyATyPyPnQSbGMiGRz8GAHgEwVkG6tX/l LlGJEOhMI+/QDocY1j9CI6RYvLmbQqR+fNXvD2gM= Date: Fri, 2 Apr 2021 11:59:39 +0300 From: Laurent Pinchart To: Xin Ji Cc: Sean Paul , Foss , Nicolas Boichat , Andrzej Hajda , devel@driverdev.osuosl.org, Jernej Skrabec , Sheng Pan , Jonas Karlman , David Airlie , Bernie Liang , Neil Armstrong , Zhen Li , LKML , dri-devel , Vasily Khoruzhick , Boris Brezillon , Torsten Duwe , Hsin-Yi Wang , Sam Ravnborg , Dan Carpenter , Marek Szyprowski Subject: Re: [PATCH v6 4/5] drm/bridge: anx7625: add HDCP support Message-ID: References: <189a637c87827f78c433a053e3c2129ebec73188.1616135353.git.xji@analogixsemi.com> <20210329102710.GA1930154@anxtwsw-Precision-3640-Tower> <20210402022708.GA2154388@anxtwsw-Precision-3640-Tower> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210402022708.GA2154388@anxtwsw-Precision-3640-Tower> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Xin, On Fri, Apr 02, 2021 at 10:27:08AM +0800, Xin Ji wrote: > On Mon, Mar 29, 2021 at 02:02:08PM -0400, Sean Paul wrote: > > On Mon, Mar 29, 2021 at 6:27 AM Xin Ji wrote: > > > > > > On Thu, Mar 25, 2021 at 02:19:23PM -0400, Sean Paul wrote: > > > > On Fri, Mar 19, 2021 at 2:35 AM Xin Ji wrote: > > > > > > > > > > Add HDCP feature, enable HDCP function through chip internal key > > > > > and downstream's capability. > > > > > > > > > > Signed-off-by: Xin Ji > > > > > --- > > > > /snip > > > > > > > static void anx7625_dp_start(struct anx7625_data *ctx) > > > > > { > > > > > int ret; > > > > > @@ -643,6 +787,9 @@ static void anx7625_dp_start(struct anx7625_data *ctx) > > > > > return; > > > > > } > > > > > > > > > > + /* HDCP config */ > > > > > + anx7625_hdcp_setting(ctx); > > > > > > > > You should really use the "Content Protection" property to > > > > enable/disable HDCP instead of force-enabling it at all times. > > > > > > Hi Sean, it's hard to implement "Content Protection" property, we have > > > implemented HDCP in firmware, it is not compatible with it. We don't > > > have interface to get Downstream Cert. > > > Thanks, > > > Xin > > > > Hi Xin, > > I'm sorry, I don't understand what you mean when you say you don't > > have an interface to get Downstream Cert. > > > > The Content Protection property is just a means through which > > userspace can turn on and turn off HDCP when it needs. As far as I can > > tell, your patch turns on HDCP when the display is enabled and leaves > > it on until it is disabled. This is undesirable since it forces HDCP > > on the user. > > > > Is it impossible to enable/disable HDCP outside of display > > enable/disable on your hardware? > > Hi Sean, I have commit a test patch on google review site, can you > please help to review it? I'll use Connector's ".atomic_check()" > interface to detect Content Protection property change. > (https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/2674580) Please note that upstream review happens on mailing lists, not in gerrit. Internal reviews for Chrome OS development are certainly fine there, but that will not mean the patch will then be accepted upstream as-is, it will still need to go through the upstream review process, without any shortcut. I strongly recommend using an upstream-first strategy, with public review. > > > > > + > > > > > if (ctx->pdata.is_dpi) > > > > > ret = anx7625_dpi_config(ctx); > > > > > else > > > > /snip -- Regards, Laurent Pinchart