From: Greg KH <gregkh@linuxfoundation.org>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
lukasz.luba@arm.com, rafael@kernel.org,
Ram Chandrasekar <rkumbako@codeaurora.org>
Subject: Re: [PATCH v6 2/7] powercap/drivers/dtpm: Create a registering system
Date: Fri, 2 Apr 2021 13:48:39 +0200 [thread overview]
Message-ID: <YGcEl8gsSIcmyLf1@kroah.com> (raw)
In-Reply-To: <c819700a-97b6-9993-491b-599b82842dc2@linaro.org>
On Fri, Apr 02, 2021 at 01:10:51PM +0200, Daniel Lezcano wrote:
> >> To answer your questions, there is a SoC vendor thermal daemon using
> >> DTPM and there is a tool created to watch the thermal framework and read
> >> the DTPM values, it is available at [4]. It is currently under
> >> development with the goal of doing power rebalancing / capping across
> >> the different nodes when there is a violation of the parent's power limit.
> >
> > Crazy ideas aside, your implementation of this is my main objection
> > here. You are creating a user/kernel api that you will have to support
> > for 20+ years, without a real userspace user just yet (from what I can
> > tell). That's rough, and is going to mean that this gets messy over
> > time.
>
> I'm not sure to understand, the API already exists since v3.3, it is the
> powercap and DTPM is its backend. AFAICT, there are already users of it
> except they create their own way to build the hierarchy today.
The configfs api is what I am referring to here, the ones in this patch
series...
thanks,
greg k-h
next prev parent reply other threads:[~2021-04-02 11:48 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 18:36 [PATCH v6 1/7] powercap/drivers/dtpm: Encapsulate even more the code Daniel Lezcano
2021-04-01 18:36 ` [PATCH v6 2/7] powercap/drivers/dtpm: Create a registering system Daniel Lezcano
2021-04-01 19:28 ` Greg KH
2021-04-01 22:08 ` Daniel Lezcano
2021-04-02 8:02 ` Greg KH
2021-04-02 11:10 ` Daniel Lezcano
2021-04-02 11:48 ` Greg KH [this message]
2021-04-01 18:36 ` [PATCH v6 3/7] powercap/drivers/dtpm: Simplify the dtpm table Daniel Lezcano
2021-11-26 17:08 ` Doug Smythies
2021-11-26 17:21 ` Rafael J. Wysocki
2021-11-26 17:43 ` Daniel Lezcano
2021-11-26 18:18 ` Rafael J. Wysocki
2021-11-26 21:56 ` Doug Smythies
2021-11-26 23:05 ` Daniel Lezcano
2021-11-26 23:08 ` [PATCH] powercap/drivers/dtpm: Disable dtpm at boot time Daniel Lezcano
2021-11-26 23:10 ` Daniel Lezcano
2021-11-27 1:13 ` Doug Smythies
2021-12-01 18:56 ` Rafael J. Wysocki
2021-11-26 19:10 ` [PATCH v6 3/7] powercap/drivers/dtpm: Simplify the dtpm table Doug Smythies
2021-11-26 19:29 ` Rafael J. Wysocki
2021-11-30 16:46 ` Daniel Lezcano
2021-11-26 17:40 ` Daniel Lezcano
2021-11-26 18:23 ` Rafael J. Wysocki
2021-04-01 18:36 ` [PATCH v6 4/7] powercap/drivers/dtpm: Use container_of instead of a private data field Daniel Lezcano
2021-04-01 18:36 ` [PATCH v6 5/7] powercap/drivers/dtpm: Scale the power with the load Daniel Lezcano
2021-04-01 18:36 ` [PATCH v6 6/7] powercap/drivers/dtpm: Export the symbols for the modules Daniel Lezcano
2021-04-01 18:36 ` [PATCH v6 7/7] powercap/drivers/dtpm: Allow dtpm node device creation through configfs Daniel Lezcano
2021-04-01 19:37 ` Greg KH
2021-04-02 10:54 ` Daniel Lezcano
2021-04-02 10:54 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGcEl8gsSIcmyLf1@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=rafael@kernel.org \
--cc=rkumbako@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox