* [PATCH] tools: perf: util: Remove duplicate struct declaration
@ 2021-04-01 6:23 Wan Jiabing
2021-04-01 7:19 ` Namhyung Kim
0 siblings, 1 reply; 3+ messages in thread
From: Wan Jiabing @ 2021-04-01 6:23 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Namhyung Kim,
Adrian Hunter, linux-kernel
Cc: kael_w, Wan Jiabing
struct target is declared twice. One has been declared
at 21st line. Remove the duplicate.
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
tools/perf/util/evsel.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/perf/util/evsel.h b/tools/perf/util/evsel.h
index 6026487353dd..998e5b806696 100644
--- a/tools/perf/util/evsel.h
+++ b/tools/perf/util/evsel.h
@@ -157,7 +157,6 @@ struct perf_missing_features {
extern struct perf_missing_features perf_missing_features;
struct perf_cpu_map;
-struct target;
struct thread_map;
struct record_opts;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] tools: perf: util: Remove duplicate struct declaration
2021-04-01 6:23 [PATCH] tools: perf: util: Remove duplicate struct declaration Wan Jiabing
@ 2021-04-01 7:19 ` Namhyung Kim
2021-04-02 13:45 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 3+ messages in thread
From: Namhyung Kim @ 2021-04-01 7:19 UTC (permalink / raw)
To: Wan Jiabing
Cc: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Adrian Hunter,
linux-kernel, kael_w
Hello,
On Thu, Apr 1, 2021 at 3:25 PM Wan Jiabing <wanjiabing@vivo.com> wrote:
>
> struct target is declared twice. One has been declared
> at 21st line. Remove the duplicate.
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
I think we can move all the forward declarations to the top
(and sort them) as well.
Thanks,
Namhyung
> ---
> tools/perf/util/evsel.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/perf/util/evsel.h b/tools/perf/util/evsel.h
> index 6026487353dd..998e5b806696 100644
> --- a/tools/perf/util/evsel.h
> +++ b/tools/perf/util/evsel.h
> @@ -157,7 +157,6 @@ struct perf_missing_features {
> extern struct perf_missing_features perf_missing_features;
>
> struct perf_cpu_map;
> -struct target;
> struct thread_map;
> struct record_opts;
>
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] tools: perf: util: Remove duplicate struct declaration
2021-04-01 7:19 ` Namhyung Kim
@ 2021-04-02 13:45 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2021-04-02 13:45 UTC (permalink / raw)
To: Namhyung Kim
Cc: Wan Jiabing, Peter Zijlstra, Ingo Molnar, Mark Rutland,
Alexander Shishkin, Jiri Olsa, Adrian Hunter, linux-kernel,
kael_w
Em Thu, Apr 01, 2021 at 04:19:38PM +0900, Namhyung Kim escreveu:
> Hello,
>
> On Thu, Apr 1, 2021 at 3:25 PM Wan Jiabing <wanjiabing@vivo.com> wrote:
> >
> > struct target is declared twice. One has been declared
> > at 21st line. Remove the duplicate.
> >
> > Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
>
> Acked-by: Namhyung Kim <namhyung@kernel.org>
>
> I think we can move all the forward declarations to the top
> (and sort them) as well.
Thanks, applied.
- Arnaldo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-02 13:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-04-01 6:23 [PATCH] tools: perf: util: Remove duplicate struct declaration Wan Jiabing
2021-04-01 7:19 ` Namhyung Kim
2021-04-02 13:45 ` Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox