From: Greg KH <gregkh@linuxfoundation.org>
To: min.li.xe@renesas.com
Cc: derek.kiernan@xilinx.com, dragan.cvetic@xilinx.com,
arnd@arndb.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH next 2/2] misc: Add Renesas Synchronization Management Unit (SMU) support
Date: Sun, 4 Apr 2021 12:08:43 +0200 [thread overview]
Message-ID: <YGmQKyweNi3lWoGM@kroah.com> (raw)
In-Reply-To: <1617487714-8312-2-git-send-email-min.li.xe@renesas.com>
On Sat, Apr 03, 2021 at 06:08:34PM -0400, min.li.xe@renesas.com wrote:
> From: Min Li <min.li.xe@renesas.com>
>
> This driver is developed for the IDT ClockMatrix(TM) and 82P33xxx families
> of timing and synchronization devices.It will be used by Renesas PTP Clock
> Manager for Linux (pcm4l) software to provide support to GNSS assisted
> partial timing support (APTS) and other networking timing functions.
>
> Current version provides kernel API's to support the following functions
> -set combomode to enable SYNCE clock support
> -read dpll's state to determine if the dpll is locked to the GNSS channel
> -read dpll's ffo (fractional frequency offset) in ppqt
>
> Signed-off-by: Min Li <min.li.xe@renesas.com>
Any specific reason you are not using the misc_device api? That would
clean up this driver a lot, there's no need to create a whole class just
for a single driver.
thanks,
greg k-h
next prev parent reply other threads:[~2021-04-04 10:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-03 22:08 [PATCH next 1/2] mfd: Add Renesas Synchronization Management Unit (SMU) support min.li.xe
2021-04-03 22:08 ` [PATCH next 2/2] misc: " min.li.xe
2021-04-04 10:08 ` Greg KH [this message]
2021-04-05 1:52 ` Min Li
2021-04-05 6:37 ` Greg KH
2021-04-05 13:53 ` Min Li
-- strict thread matches above, loose matches on Subject: below --
2021-03-26 15:34 min.li.xe
2021-03-27 7:58 ` kernel test robot
2021-03-27 9:53 ` kernel test robot
2021-03-28 12:13 ` Greg KH
2021-03-29 17:03 ` Min Li
2021-04-02 14:22 ` Greg KH
2021-04-03 22:06 ` Min Li
2021-03-23 16:40 min.li.xe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGmQKyweNi3lWoGM@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=derek.kiernan@xilinx.com \
--cc=dragan.cvetic@xilinx.com \
--cc=linux-kernel@vger.kernel.org \
--cc=min.li.xe@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox