Re: [PATCH next 2/2] misc: Add Renesas Synchronization Management Unit (SMU) support

Greg KH
2021-04-05T06:37:18Z

On Mon, Apr 05, 2021 at 01:52:39AM +0000, Min Li wrote:
> >
> > Any specific reason you are not using the misc_device api? That would clean
> > up this driver a lot, there's no need to create a whole class just for a single
> > driver.
> >
>
> Hi Greg
>
> No specific reason. I just didn't know the existence of misc_register API.

Your file is in drivers/misc/ :)

> Do you recommend using this API to create the device?

Yes.

> If yes, can you tell me how to obtain a appropriate MINOR number from
> miscdevice.h?

No need to reserve one, we don't do that anymore, just ask for a dynamic
value and the next availble one will be given to your driver
automatically.

thanks,

greg k-h