From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Wan Jiabing <wanjiabing@vivo.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Kan Liang <kan.liang@linux.intel.com>,
Leo Yan <leo.yan@linaro.org>, Ian Rogers <irogers@google.com>,
linux-kernel@vger.kernel.org, kael_w@yeah.net
Subject: Re: [PATCH] perf: util/mem-events.h: Remove unnecessary struct declaration
Date: Tue, 6 Apr 2021 13:33:12 -0300 [thread overview]
Message-ID: <YGyNSMDNlxQk5j7E@kernel.org> (raw)
In-Reply-To: <20210406105104.675879-1-wanjiabing@vivo.com>
Em Tue, Apr 06, 2021 at 06:51:02PM +0800, Wan Jiabing escreveu:
> struct mem_info is defined at 22nd line.
> The declaration here is unnecessary. Remove it.
Thanks, applied.
- Arnaldo
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> tools/perf/util/mem-events.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/perf/util/mem-events.h b/tools/perf/util/mem-events.h
> index 755cef7e0625..5ddbeaa057b0 100644
> --- a/tools/perf/util/mem-events.h
> +++ b/tools/perf/util/mem-events.h
> @@ -44,7 +44,6 @@ bool is_mem_loads_aux_event(struct evsel *leader);
>
> void perf_mem_events__list(void);
>
> -struct mem_info;
> int perf_mem__tlb_scnprintf(char *out, size_t sz, struct mem_info *mem_info);
> int perf_mem__lvl_scnprintf(char *out, size_t sz, struct mem_info *mem_info);
> int perf_mem__snp_scnprintf(char *out, size_t sz, struct mem_info *mem_info);
> --
> 2.25.1
>
--
- Arnaldo
prev parent reply other threads:[~2021-04-06 16:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 10:51 [PATCH] perf: util/mem-events.h: Remove unnecessary struct declaration Wan Jiabing
2021-04-06 16:33 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGyNSMDNlxQk5j7E@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@redhat.com \
--cc=kael_w@yeah.net \
--cc=kan.liang@linux.intel.com \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=wanjiabing@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox