From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD803C43460 for ; Mon, 19 Apr 2021 17:15:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 99D5F61245 for ; Mon, 19 Apr 2021 17:15:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239653AbhDSRQX (ORCPT ); Mon, 19 Apr 2021 13:16:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:34206 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232572AbhDSRQV (ORCPT ); Mon, 19 Apr 2021 13:16:21 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 79E0C611F0; Mon, 19 Apr 2021 17:15:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1618852551; bh=8KyYHrpSSLZ6bzyctVHE3NpW0Q8UJehavMJQewTSjQA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZMQfD3Jv2VKCkamBmuh6Df5UtWFjpD44ZXsp4C26QcuDgR/ZPXSuZy7joN+k2GR71 f7LpvyVMkAdCu+XXopx7ISNraTUQxaJaBwKcqlSkZlAA5WVboWoCWZPlpetDkM1nte krP7/ia6qw5f7sfILmQRKy/Ez8QsbHL/Tjlzv0U1p5dfVe6XpkwQrQhaFzTBQdwRCf tyDZa8EfdfReF+vaZjgKzAyf4tX1CJY9XFdtFM3SA4SupSCBm+mc1iK8Z8jLLSUxOu Sa7QRfiajQVflf8FGTSt60COO6QgZHSyoO+JrBI9v85GS4zZ9jU6ULENttDG2Na1Ap LpIxfIQnDS4zQ== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id E385D40647; Mon, 19 Apr 2021 14:15:48 -0300 (-03) Date: Mon, 19 Apr 2021 14:15:48 -0300 From: Arnaldo Carvalho de Melo To: Peter Zijlstra Cc: Dan Carpenter , Muhammad Usama Anjum , Josh Poimboeuf , Ingo Molnar , Miroslav Benes , Borislav Petkov , open list , kernel-janitors@vger.kernel.org, colin.king@canonical.com Subject: Re: [PATCH] objtool: prevent memory leak in error paths Message-ID: References: <20210413204511.GA664936@LEGION> <20210414084709.GT6021@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, Apr 15, 2021 at 09:24:41AM +0200, Peter Zijlstra escreveu: > On Wed, Apr 14, 2021 at 11:47:09AM +0300, Dan Carpenter wrote: > > On Wed, Apr 14, 2021 at 01:45:11AM +0500, Muhammad Usama Anjum wrote: > > > Memory allocated by sym and sym->name isn't being freed if some error > > > occurs in elf_create_undef_symbol(). Free the sym and sym->name if error > > > is detected before returning NULL. > > > > > > Addresses-Coverity: ("Prevent memory leak") > > > Fixes: 2f2f7e47f052 ("objtool: Add elf_create_undef_symbol()") > > > Signed-off-by: Muhammad Usama Anjum > > > --- > > > Only build has been tested. > > > > > > > Just ignore leaks from the tools/ directory. These things run and then > > exit and all the memory is freed. #OldSchoolGarbageCollector > > Mostly true; but I suspect tools/perf might care, it has some longer > running things in. Yes, and now we have 'perf daemon' that is long running. - Arnaldo