From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D194EC433ED for ; Tue, 20 Apr 2021 17:29:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9933B613B8 for ; Tue, 20 Apr 2021 17:29:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233362AbhDTRaZ (ORCPT ); Tue, 20 Apr 2021 13:30:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233245AbhDTRaX (ORCPT ); Tue, 20 Apr 2021 13:30:23 -0400 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57AE5C06138B for ; Tue, 20 Apr 2021 10:29:52 -0700 (PDT) Received: by mail-pj1-x1033.google.com with SMTP id f11-20020a17090a638bb02901524d3a3d48so233496pjj.3 for ; Tue, 20 Apr 2021 10:29:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=oHhObtzZUMwUL0LGBYnUP2PdgBkn1gCTVPbp4qMchG4=; b=YScpteqoqCLz2Eu+NTR3fLnysuCLD0EMwVENM3M1OUKcSsSnzqJcHaNC4pfaNry8tw RPWH7MrHzN59I3/0KGYanyTHJAzmj2yiQtwZwDgHuRJfBEpZNi3im67N4vuRuH2YMwAh wSkveHOydiGEs4NcfcUJdwx69c4CsvCe+uqI4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=oHhObtzZUMwUL0LGBYnUP2PdgBkn1gCTVPbp4qMchG4=; b=EKMww3Pb4sAhvam9Dha6FqPcO6j3ucQLQwcoQ67QfCrH1yttfH3WqGh3Rvehc1Y+D4 o/3ShoTsrCjgstu59+VyYapgNmZ8va9PInYM97MW5Rp2QcGCy8CvAecQS7QEBpgB0OdE Yo1dUL+JqwBvcw2r2TxZYv4WldAWDfCgnQNuDjq7pMYp6TzA0cNP67Bg61lujPdYagwj nSJ5V9e8x37PmVmPsPlGJRHa/RGfvivVKaIdt7EsHaJI35sUQl0/T4NF7dviyxXV/kxM VFd8EdFTx2Bwt197TtK22OHZmF3VzuNglG+BwBIJEPSD0fOQrec6k3LGrZ4P2aWcPIGU qlUA== X-Gm-Message-State: AOAM533iAC3ShPKpk/aA48CSxqJ6qwTObpvo14gCOKYa5QzbSgccbWk5 kpMIhHXIN2BcJM8xhZpVkCwTBQ== X-Google-Smtp-Source: ABdhPJxEe1OhULxbGxmNL1UjWRteTSkCWq9GXRDRscjlFfY5QPkDI7MHsA7OpxA3teahomRVWUToQg== X-Received: by 2002:a17:90a:7897:: with SMTP id x23mr6106182pjk.133.1618939791774; Tue, 20 Apr 2021 10:29:51 -0700 (PDT) Received: from localhost ([2620:15c:202:201:7a9:7e56:e9c3:13e8]) by smtp.gmail.com with UTF8SMTPSA id q3sm3025116pja.37.2021.04.20.10.29.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Apr 2021 10:29:51 -0700 (PDT) Date: Tue, 20 Apr 2021 10:29:50 -0700 From: Matthias Kaehlcke To: satya priya Cc: Andy Gross , Bjorn Andersson , Rob Herring , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, kgunda@codeaurora.org Subject: Re: [RESEND PATCH V3 4/5] arm64: dts: qcom: pmk8350: Add PMIC peripherals for pmk8350 Message-ID: References: <1618398783-7834-1-git-send-email-skakit@codeaurora.org> <1618398783-7834-3-git-send-email-skakit@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1618398783-7834-3-git-send-email-skakit@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 14, 2021 at 04:43:00PM +0530, satya priya wrote: > Subject: arm64: dts: qcom: pmk8350: Add PMIC peripherals for pmk8350 nit: why 'PMIC peripherals', are these peripherals somehow specific to PMICs? > Add PON, RTC and other PMIC infra modules support for PMK8350. nit: it seems somewhat arbitrary to specifically mention PON and RTC, and then treat the ADC and the thermal monitor as 'others'. You could just spell them out too. > > Signed-off-by: satya priya > --- > arch/arm64/boot/dts/qcom/pmk8350.dtsi | 55 ++++++++++++++++++++++++++++++++++- > 1 file changed, 54 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/pmk8350.dtsi b/arch/arm64/boot/dts/qcom/pmk8350.dtsi > index 1530b8f..bbd9fa7 100644 > --- a/arch/arm64/boot/dts/qcom/pmk8350.dtsi > +++ b/arch/arm64/boot/dts/qcom/pmk8350.dtsi > @@ -3,6 +3,12 @@ > * Copyright (c) 2021, Linaro Limited > */ > > +#include > +#include > +#include > +#include the includes of the constants for the other PMICs seems to be an remainder from older vesions, which included nodes for the on die temperatures of these PMICs.