From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D15EDC433ED for ; Fri, 9 Apr 2021 14:33:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A506160190 for ; Fri, 9 Apr 2021 14:33:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233796AbhDIOdh (ORCPT ); Fri, 9 Apr 2021 10:33:37 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:56089 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S231946AbhDIOdf (ORCPT ); Fri, 9 Apr 2021 10:33:35 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 139EWmYC019758 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 9 Apr 2021 10:32:48 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 0A5C315C3B12; Fri, 9 Apr 2021 10:32:48 -0400 (EDT) Date: Fri, 9 Apr 2021 10:32:47 -0400 From: "Theodore Ts'o" To: "Matthew Wilcox (Oracle)" Cc: neilb@suse.de, peterz@infradead.org, mingo@redhat.com, will@kernel.org, longman@redhat.com, boqun.feng@gmail.com, tglx@linutronix.de, bigeasy@linutronix.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/17] bit_spinlock: Prepare for split_locks Message-ID: References: <20210409025131.4114078-1-willy@infradead.org> <20210409025131.4114078-4-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210409025131.4114078-4-willy@infradead.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 09, 2021 at 03:51:17AM +0100, Matthew Wilcox (Oracle) wrote: > Make bit_spin_lock() and variants variadic to help with the transition. > The split_lock parameter will become mandatory at the end of the series. > Also add bit_spin_lock_nested() and bit_spin_unlock_assign() which will > both be used by the rhashtable code later. > > Signed-off-by: Matthew Wilcox (Oracle) This changes the function signature for bit_spin_lock(), if I'm reading this correctly. Hence, this is going to break git bisectability; was this patch series separated out for easy of review, and you were planning on collapsing things into a single patch to preserve bisectability? - Ted