From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72135C433ED for ; Fri, 9 Apr 2021 16:56:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4CAA16102A for ; Fri, 9 Apr 2021 16:56:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234246AbhDIQ4f (ORCPT ); Fri, 9 Apr 2021 12:56:35 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:56663 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S234239AbhDIQ4a (ORCPT ); Fri, 9 Apr 2021 12:56:30 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 139GtpX5021793 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 9 Apr 2021 12:55:51 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 2EBA415C3B12; Fri, 9 Apr 2021 12:55:51 -0400 (EDT) Date: Fri, 9 Apr 2021 12:55:51 -0400 From: "Theodore Ts'o" To: Ritesh Harjani Cc: Shaokun Zhang , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, Yang Guo , Andreas Dilger Subject: Re: [PATCH] ext4: Delete redundant uptodate check for buffer Message-ID: References: <1617260610-29770-1-git-send-email-zhangshaokun@hisilicon.com> <20210401112001.tjwjfrno4ygwwzh2@riteshh-domain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210401112001.tjwjfrno4ygwwzh2@riteshh-domain> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 01, 2021 at 04:50:01PM +0530, Ritesh Harjani wrote: > On 21/04/01 03:03PM, Shaokun Zhang wrote: > > From: Yang Guo > > > > The buffer uptodate state has been checked in function set_buffer_uptodate, > > there is no need use buffer_uptodate before calling set_buffer_uptodate and > > delete it. > > > > Cc: "Theodore Ts'o" > > Cc: Andreas Dilger > > Signed-off-by: Yang Guo > > Signed-off-by: Shaokun Zhang > > --- > > fs/ext4/inode.c | 6 ++---- > > 1 file changed, 2 insertions(+), 4 deletions(-) > > Thanks for the patch. Changes looks good and trivial. > > Feel free to add - > Reviewed-by: Ritesh Harjani Thanks, applied. - Ted